⚡ Bolt: Optimize LuaServerModule queries to use O(1) game singletons - #241
⚡ Bolt: Optimize LuaServerModule queries to use O(1) game singletons#241mleem97 wants to merge 1 commit into
Conversation
Replaced expensive FindObjectsOfType calls in LuaServerModule with O(1) NetworkMap dictionary lookups. Added defensive fallback if dictionaries are not initialized. Extracted logging out of critical section in CablePositionsPatch.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for security reviews. Please try again later. |
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Security | 1 high |
🟢 Metrics 18 complexity · 1 duplication
Metric Results Complexity 18 Duplication 1
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
💡 What: Replaced
FindObjectsOfType<Il2Cpp.Server>()withIl2Cpp.NetworkMap.instance.serversandbrokenServersinLuaServerModule(get_all,repair,repair_all). Includes defensive list copy forrepair_allmutation loop.🎯 Why:
FindObjectsOfTypeis extremely expensive, scanning the entire Unity scene hierarchy.NetworkMapdictionaries provide direct O(1) lookups and significantly reduce GC pressure, heavily boosting performance when executing these Lua scripts.📊 Impact: Eliminates large CPU spikes and O(N) allocations for Lua execution.
🔬 Measurement: Observe CPU frame time using Unity Profiler while executing
greg.server.get_all()orgreg.server.repair_all()in heavily populated server rooms.PR created automatically by Jules for task 11247273667056723275 started by @mleem97