Potential fix for code scanning alert no. 12: Server-side request forgery - #97
Draft
moderniselife wants to merge 1 commit into
Draft
moderniselife wants to merge 1 commit into
moderniselife wants to merge 1 commit into
Conversation
…gery Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/moderniselife/SchroDrive/security/code-scanning/12
To fix this without changing intended behavior, keep accepting
http/httpstorrent URLs but add defense-in-depth on the actual HTTP client call insrc/providers/registry.ts:new URL(...)after validation.axios.get.maxRedirects: 0) so a public URL cannot bounce to internal/private targets.This is the safest minimal change in the shown code region and addresses both alert variants because they converge on the same sink (
addTorrentFileFromUrlline 243 path).Edit only
src/providers/registry.tsin theaddTorrentFileFromUrlmethod around lines 242–248.Suggested fixes powered by Copilot Autofix. Review carefully before merging.