Skip to content

Potential fix for code scanning alert no. 12: Server-side request forgery #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
moderniselife wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Potential fix for code scanning alert no. 12: Server-side request forgery #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/providers/registry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,12 +240,14 @@
let fileBuffer: Buffer;
try {
assertPublicHttpUrl(torrentUrl);
const resp = await axios.get(torrentUrl, {
const safeUrl = new URL(torrentUrl).toString();
const resp = await axios.get(safeUrl, {
responseType: 'arraybuffer',
timeout: 30000,
maxRedirects: 0,
httpAgent: new http.Agent({ family: 4 }),
httpsAgent: new https.Agent({ family: 4 }),
});

Check failure

Code scanning / CodeQL

Server-side request forgery Critical

The
URL
Loading
of this request depends on a
user-provided value
Loading
.
The
URL
Loading
of this request depends on a
user-provided value
Loading
.
fileBuffer = Buffer.from(resp.data);
console.log(`[${new Date().toISOString()}][registry] Downloaded .torrent file (${fileBuffer.length} bytes)`);
} catch (err: any) {
Expand Down
Loading