Skip to content

[fix] 추천 지역 대표 좌표 중복 방지 #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
worudgks98 merged 1 commit into from
Sep 22, 2026
Merged

[fix] 추천 지역 대표 좌표 중복 방지 #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 55 additions & 6 deletions src/main/java/com/moive/MoiveBE/domain/recommendation/service/AreaCandidateResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
import lombok.extern.slf4j.Slf4j;
import org.springframework.stereotype.Service;

import java.util.Set;

@Slf4j
@Service
@RequiredArgsConstructor
Expand All @@ -16,7 +18,9 @@ public class AreaCandidateResolver {
public GooglePlaceSearchResponse.Place resolve(
String areaName,
double centerLatitude,
double centerLongitude
double centerLongitude,
Set<String> usedPlaceIds,
Set<String> usedCoordinates
) {

log.info(
Expand All @@ -35,7 +39,11 @@ public GooglePlaceSearchResponse.Place resolve(
);

GooglePlaceSearchResponse.Place subwayPlace =
getValidPlace(subwayResponse);
getValidPlace(
subwayResponse,
usedPlaceIds,
usedCoordinates
);

if (subwayPlace != null) {
return subwayPlace;
Expand All @@ -50,7 +58,11 @@ public GooglePlaceSearchResponse.Place resolve(
);

GooglePlaceSearchResponse.Place transitPlace =
getValidPlace(transitResponse);
getValidPlace(
transitResponse,
usedPlaceIds,
usedCoordinates
);

if (transitPlace != null) {
return transitPlace;
Expand All @@ -64,11 +76,17 @@ public GooglePlaceSearchResponse.Place resolve(
centerLongitude
);

return getValidPlace(areaResponse);
return getValidPlace(
areaResponse,
usedPlaceIds,
usedCoordinates
);
}

private GooglePlaceSearchResponse.Place getValidPlace(
GooglePlaceSearchResponse response
GooglePlaceSearchResponse response,
Set<String> usedPlaceIds,
Set<String> usedCoordinates
) {

if (response == null
Expand All @@ -92,12 +110,43 @@ private GooglePlaceSearchResponse.Place getValidPlace(
return null;
}

if (usedPlaceIds.contains(place.id())) {
log.info(
"지역 좌표 중복 - 이미 사용된 Google Place - placeId={}",
place.id()
);
return null;
}

String coordinateKey =
createCoordinateKey(
place.location().latitude(),
place.location().longitude()
);

if (usedCoordinates.contains(coordinateKey)) {
log.info(
"지역 좌표 중복 - 이미 사용된 좌표 - latitude={}, longitude={}",
place.location().latitude(),
place.location().longitude()
);
return null;
}

log.info(
"지역 좌표 조회 성공 - place=({}, {})",
"지역 좌표 조회 성공 - placeId={}, place=({}, {})",
place.id(),
place.location().latitude(),
place.location().longitude()
);

return place;
}

public String createCoordinateKey(
double latitude,
double longitude
) {
return latitude + "," + longitude;
}
}
63 changes: 45 additions & 18 deletions ...ain/java/com/moive/MoiveBE/domain/recommendation/service/RecommendedAreaQueryService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,10 @@
import lombok.RequiredArgsConstructor;
import org.springframework.stereotype.Service;

import java.util.ArrayList;
import java.util.HashSet;
import java.util.List;
import java.util.Set;

@Service
@RequiredArgsConstructor
Expand Down Expand Up @@ -54,24 +57,51 @@ public RecommendedAreaListResponse getRecommendedAreas(
List<AreaCandidate> candidates =
legalDongCandidateService.generate(center);

Set<String> usedPlaceIds = new HashSet<>();
Set<String> usedCoordinates = new HashSet<>();

List<RecommendedAreaListResponse.Area> areas =
recommendedAreas.stream()
.map(recommendedArea ->
toResponse(
recommendedArea,
center,
candidates
)
)
.toList();
new ArrayList<>();

for (RecommendedArea recommendedArea : recommendedAreas) {

GooglePlaceSearchResponse.Place place =
resolvePlace(
recommendedArea,
center,
candidates,
usedPlaceIds,
usedCoordinates
);

usedPlaceIds.add(place.id());

usedCoordinates.add(
areaCandidateResolver.createCoordinateKey(
place.location().latitude(),
place.location().longitude()
)
);

areas.add(
new RecommendedAreaListResponse.Area(
recommendedArea.getId(),
recommendedArea.getAreaName(),
place.location().latitude(),
place.location().longitude()
)
);
}

return new RecommendedAreaListResponse(areas);
}

private RecommendedAreaListResponse.Area toResponse(
private GooglePlaceSearchResponse.Place resolvePlace(
RecommendedArea recommendedArea,
AreaCenter center,
List<AreaCandidate> candidates
List<AreaCandidate> candidates,
Set<String> usedPlaceIds,
Set<String> usedCoordinates
) {

AreaCandidate candidate =
Expand All @@ -92,7 +122,9 @@ private RecommendedAreaListResponse.Area toResponse(
areaCandidateResolver.resolve(
candidate.searchName(),
center.latitude(),
center.longitude()
center.longitude(),
usedPlaceIds,
usedCoordinates
);

if (place == null || place.location() == null) {
Expand All @@ -101,11 +133,6 @@ private RecommendedAreaListResponse.Area toResponse(
);
}

return new RecommendedAreaListResponse.Area(
recommendedArea.getId(),
recommendedArea.getAreaName(),
place.location().latitude(),
place.location().longitude()
);
return place;
}
}
5 changes: 4 additions & 1 deletion ...com/moive/MoiveBE/domain/recommendation/service/AreaCandidateResolverIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import org.springframework.boot.test.context.SpringBootTest;

import java.util.List;
import java.util.Set;

import static org.assertj.core.api.Assertions.assertThat;

Expand Down Expand Up @@ -73,7 +74,9 @@ class AreaCandidateResolverIntegrationTest {
areaCandidateResolver.resolve(
namMyeon.searchName(),
center.latitude(),
center.longitude()
center.longitude(),
Set.of(),
Set.of()
);

System.out.println(
Expand Down
Loading
Loading