fix: emit ecrecover authorizer signer#966
Conversation
Include the recovered signer in the EcrecoverAuthorizer SetIsAuthorized event so offchain consumers can reconstruct who signed delegated authorizations.
| address indexed authorized, | ||
| bool isAuthorized, | ||
| uint256 nonce, | ||
| address signer |
There was a problem hiding this comment.
not sure where to put it, no clear consensus (github search), also don't think it matters much
Use the no-argument Foundry expectEmit helper in the signer event regression test.
This reverts commit 18194ab.
MathisGD
left a comment
MathisGD
left a comment
There was a problem hiding this comment.
Nb: EcrecoverRatifier.isRatified also recovers _signer and accepts delegated signers, but no event exposes the signer. Harder to fix because isRatified is view... Have we thought about this when passing the ratification as view?
…orizer-signer-event-1780397877
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a0ea694455
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This reverts commit e7c70aa.
3 participants
Adds the recovered
signeraddress toEcrecoverAuthorizer.SetIsAuthorized.