Conversation
…leanup callbacks to the constructor before the server is stopped.
kevinzakka
approved these changes
Jul 29, 2026
Author
|
Hey I just noticed this is still open. I am a bit confused by the error, as I haven't changed the README.md. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the wonderful repo!
I noticed that the viewer takes full possession of the
ViserServerpassed in during construction. This means when the viewer is shut down, it kills the server, no questions asked. This pr introduces custom cleanup callbacks so that we can clean up some resources before the server is killed.Personally, I'd find it helpful to let the user decide if the server is to be shut down on exit or not. When prototyping stuff in a notebook, I found it to be quite annoying that a new
ViserServerwith ever-increasing port number is created.