Fix doc wording/clarity and stabilize Playground date/link identifiers#448
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0a3d496230
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| `depth` indicates the container level in the nested route tree: use `depth: 1` for a top-level | ||
| container, `depth: 2` for a container nested inside it, and so on. |
There was a problem hiding this comment.
Describe depth as recursion depth, not route level
This added explanation says depth is the container's nesting level, but the container code passes it to menuItemsFromRoute(..., depth), where it controls how many descendant route levels to include from the current container (1 is immediate children). A top-level SideMenuContainer that should include grandchildren therefore needs depth: 2—as the example below does—so following this text would hide nested entries rather than configure nested containers correctly.
Useful? React with 👍 / 👎.
| const startDate = new Date(currentYear, 0, 1) | ||
| const endDate = new Date(currentYear, 1, 28) |
There was a problem hiding this comment.
Align Gantt bounds with generated activity dates
When this demo is opened in any year other than 2026, these bounds use currentYear, but every generated row/activity/fill segment below still uses new Date(2026, ...). Since GanttChartComponent builds its visible dateRange from startDate/endDate, the playground will show a non-2026 calendar while rendering 2026 activities clamped into that grid, making hover dates and link validation misleading. Derive all activity dates from the same year or keep the range fixed/documented.
Useful? React with 👍 / 👎.
This PR applies the requested copy and behavior fixes across Django and Vue surfaces: grammar/spelling corrections in docs, clearer guidance for nested container
depth, and deterministic demo logic updates to avoid future-dated defaults and duplicate link IDs.Django package description
nside_wefamodule docstring to use a grammatically complete list (..., data protection, and authentication.).Router container Storybook docs
overview.mdx(multiples→multiple).depthsemantics for nested containers so consumers can map route nesting level todepthvalues (1,2, ...).Playground Gantt demo behavior
currentYear-based dates.Original prompt