Skip to content

Fix doc wording/clarity and stabilize Playground date/link identifiers #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −65
Open

Fix doc wording/clarity and stabilize Playground date/link identifiers #448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d1aefa
Initial plan
Copilot Jul 3, 2026
0a3d496
fix docs and demo date/link identifiers
Copilot Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion django/nside_wefa/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
nside-demo: Django library with utilities and reusable apps.

This package provides Django applications and utilities for web development,
with a focus on Legal Consent compliance, data protection, authentication.
with a focus on Legal Consent compliance, data protection, and authentication.
"""

__version__ = "0.6.2"
60 changes: 0 additions & 60 deletions vue/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion vue/src/containers/storybook/overview.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ In your router definition, if multiple routes/views should be grouped in a certa

**If one of your route has children routes, you MUST use a Container Component on it.** Router depth tracking depends on it.

Let's take the example of a settings panel which contains multiples views for password reset, api token and user preferences :
Let's take the example of a settings panel which contains multiple views for password reset, api token and user preferences :

```ts
/** router.ts*/
Expand Down Expand Up @@ -191,6 +191,9 @@ routes: [
You can also have deeper hierarchy, with children of children. This is useful when one section owns a
second local navigation level.

`depth` indicates the container level in the nested route tree: use `depth: 1` for a top-level
container, `depth: 2` for a container nested inside it, and so on.
Comment on lines +194 to +195

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Describe depth as recursion depth, not route level

This added explanation says depth is the container's nesting level, but the container code passes it to menuItemsFromRoute(..., depth), where it controls how many descendant route levels to include from the current container (1 is immediate children). A top-level SideMenuContainer that should include grandchildren therefore needs depth: 2—as the example below does—so following this text would hide nested entries rather than configure nested containers correctly.

Useful? React with 👍 / 👎.


```ts
/** router.ts*/

Expand Down
7 changes: 4 additions & 3 deletions vue/src/demo/views/PlaygroundView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,9 @@ import { useI18nLib } from '@/locales'

const { t } = useI18nLib()

const startDate = new Date(2026, 0, 1)
const endDate = new Date(2026, 1, 28)
const currentYear = new Date().getFullYear()
const startDate = new Date(currentYear, 0, 1)
const endDate = new Date(currentYear, 1, 28)
Comment on lines +43 to +44

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Align Gantt bounds with generated activity dates

When this demo is opened in any year other than 2026, these bounds use currentYear, but every generated row/activity/fill segment below still uses new Date(2026, ...). Since GanttChartComponent builds its visible dateRange from startDate/endDate, the playground will show a non-2026 calendar while rendering 2026 activities clamped into that grid, making hover dates and link validation misleading. Derive all activity dates from the same year or keep the range fixed/documented.

Useful? React with 👍 / 👎.

const okLinkClass = '[stroke-dasharray:2,5]'
const linkCases = [
{ type: 'start-start', fromIndex: 2, toIndex: 0, color: 'green', class: okLinkClass },
Expand Down Expand Up @@ -188,7 +189,7 @@ const links = computed<GanttChartLinkData[]>(() => {
)
if (from?.id && to?.id) {
linkPairs.push({
id: linkCase.type,
id: `${linkCase.fromIndex}-${linkCase.toIndex}-${linkCase.type}`,
fromId: from.id,
toId: to.id,
type: linkCase.type,
Expand Down
Loading