Skip to content

Cumulus 1626 node 10 - #1393

Merged
Jkovarik merged 8 commits into
masterfrom
CUMULUS-1626-node-10
Dec 17, 2019
Merged

Cumulus 1626 node 10#1393
Jkovarik merged 8 commits into
masterfrom
CUMULUS-1626-node-10

Conversation

@Jkovarik

@Jkovarik Jkovarik commented Dec 14, 2019

Copy link
Copy Markdown
Member

Summary: Summary of changes

Addresses CUMULUS-1626: Update Cumulus to be node 10 compatible

Changes

  • Config/environment/doc updates to set all Cumulus core lambdas to deploy to a node 10.x runtime
  • Update all node lambdas to utilize cumulus-message-adapter-js v1.1.0
  • Update Core configuration to use cumulus-message-adapter v1.1.2
  • Update log handling code to be compatible with AWS Linux and AWS Linux 2 node log output

PR Checklist

  • Update CHANGELOG
  • [ X ] Unit tests
  • [ X ] Adhoc testing
  • [ X ] Integration tests

* Update all terraform lambda env targets to node10.x
* Update all node references to 10.16.3 (AWS lambda env)
* Update all aws-sdk version references to ^2.585.0
* Explicitly pin ssh2-streams to ^0.4.8

@chuckwondo chuckwondo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jkovarik

Jkovarik commented Dec 16, 2019

Copy link
Copy Markdown
Member Author

2828a24 is a crummy solution to the issue discussed here: sergi/jsftp#288 sergi/jsftp#284. I'm adding a Jira ticket to move away from js-ftp as it's clearly no longer maintained.

@Jkovarik
Jkovarik merged commit 58a766d into master Dec 17, 2019
@Jkovarik Jkovarik mentioned this pull request Dec 17, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants