848 add rf inviews and delays to radio sim

[msuder]

Summary of PR goals.

How to test?

TEST 1:

• Modify the cfg/sims/nos3-simulator.xml file GENERIC_RADIO_42_PROVIDER section to have uplink-close-criteria of "occulted", uplink-delay-on to "true", downlink-close-criteria of "occulted", and downlink-delay-on to "true".
• make config; make -j; make launch
• Try to send CFS_RADIO CFE_ES_NOOP command... verify in the flight software window that nothing is received since GSFC is not inview of the satellite at the very beginning of the scenario
• Wait until 17:44:30. Try to send CFS_RADIO CFE_ES_NOOP command again... verify in the software window that the NOOP is received since GSFC is now inview of the satellite

TEST 2:

• Modify nos3-mission.xml to have scenario "DeepSpace"
• make config; make -j; make launch
• Send CFS_RADIO CFE_ES_NOOP command. Verify that it is not seen immediately in the flight software window but takes a little over 1 second to be seen (delay time from Goldstone, Earth to satellite in orbit about the moon). In contrast, the second NOOP sent in TEST 1 should have been seen in the flight software window immediately since the delay from GSFC, Earth to a satellite in low earth orbit about the Earth is negligible.

Submodule PRs and actions prior to closing this:

• 848 add rf inviews and delays to radio sim nasa-itc/generic_radio#21
• https://github.com/nasa/nos3/issues/848 - Fix typos. nasa-itc/generic_fss#19

Closes #848.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.06%. Comparing base (6f2e4a2) to head (86a50f1).
⚠️ Report is 32 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #852      +/-   ##
==========================================
- Coverage   72.75%   72.06%   -0.70%     
==========================================
  Files         761      761              
  Lines       90262    91123     +861     
  Branches     7137     7291     +154     
==========================================
- Hits        65668    65664       -4     
- Misses      24594    25459     +865     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[zlynch2]

@msuder
Test 1 and Test 2 works for me. 2 immediate Comments:

1- Can we make the spacecraft more realistic for the deep space scenario around the moon.

2 - I think we should document this in a scenario for the next release here. It may be useful to note the times at which the spacecraft falls in/out of view for commanding in the different scenarios. Note this scenario does not need to be completed for this PR but will need for the Release. Feel free to make a new issue to document this in a scenario

Also note, the delays seem to work well with the normal gateway scenario as well.

[zlynch2]

fixed multi GDS with above commit

[msuder]

1. Changed spacecraft to the IonCruiser.obj to be a more realistic satellite around the moon.
2. Wrote issue Document RF Inviews/Delays Scenario #854 to document the R/F scenario.

[zlynch2]

Tests passed and I beleive we have worked through the tweaks, tested fprime, multi GDS, and nominal nos3 as well. Approving.

[zlynch2]

Noticed Yamcs doesnt launch without multiGDS, looking into fix with yamcs launch script.

[kevincbruce]

Both scenarios worked for me!

[Isgaroth-the-Green]

Test 1 works fine for me; when I try to run Test 2, though, there does not appear to be any delay (the NOOP goes through pretty much instantly).

[zlynch2]

I fixed yamcs launching problems by removing sleeps and configuring the tcp connection to iteratively check for cryptolib container rather than sleeping. This makes the sim more robust.

[kevincbruce]

Reverified both scenarios after Zach's commit. Still works for me, so approving.

[mattilynwalker]

Both Test 1 and Test 2 worked successfully.

[zlynch2]

approving, seeing I think we fixed some cfg issues. Will merge into dev