Repository navigation
orchestrator: the fault-recovery test expects at least one pass after the heartbeat (#555) - #556
Merged
Merged
Conversation
… the heartbeat, since a queued refs or completion pass may follow it (#555)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #555.
What this changes and why
One assertion in
several-engines.test.tschanges. The fault-recovery test now expects the heartbeat to run at least one pass instead of exactly one. It failed once on main after #550 merged (expected 2 to be 1, run 36442605821, first attempt); the re-run passed.When alpha recovers, its pass dispatches. The commits that makes, or the fake dispatcher settling, can queue a refs or completion pass while the heartbeat pass is still running. The loop starts that queued pass before the heartbeat's trigger returns, so the count reads 2. That second pass is correct behaviour, so the assertion was the wrong part.
The looser assertion still pins the retry. Every pass before the heartbeat backed off, so any count above zero came from the heartbeat.
Evidence
expected 2 to be 1, the CI message; the new one passes.triggers.ts(!isBoundary(why)→why !== 'startup'): the new assertion fails withexpected 0 to be greater than or equal to 1. Restored.several-engines.test.ts20 times in a row: 20 passed (68 tests each).orchestrator/testsuite 5 times in a row: 5 passed (515 passed, 2 skipped each).npm run typecheckandnpm run lint: exit 0.Checklist
gateline render --checkpasses (rendered agents current)roles/orcontracts/packages/frameworkstill takes no runtime dependenciesnpm testis left to CI, since only this test file changedruns/