Skip to content

orchestrator: the fault-recovery test expects at least one pass after the heartbeat (#555) #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nathancrtr merged 1 commit into from
Sep 28, 2026
Merged

orchestrator: the fault-recovery test expects at least one pass after the heartbeat (#555) #556

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/orchestrator/test/several-engines.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,9 +413,13 @@ describe('fault isolation: one engine failing leaves the others running', () =>
// Later faults of the same streak log their message and no stack.
expect(lines.filter((l) => l.startsWith('[alpha] stack: '))).toHaveLength(1)
// The heartbeat still retries: after the fault clears, alpha recovers and dispatches.
// At least one pass, not exactly one (#555): the recovered pass's own commits
// and settlement can queue a refs or completion pass while it runs, and that
// pass starts before the heartbeat's trigger returns. Every pass before the
// heartbeat backed off, so any count above zero is the heartbeat's retry.
broken = false
await ea!.loop.trigger('heartbeat')
expect(ticks).toBe(1)
expect(ticks).toBeGreaterThanOrEqual(1)
expect((await health(a.dir)).failed).toBeUndefined()
expect(lines.some((l) => /^\[alpha\] recovered after \d fault\(s\) — engine no longer marked failed for its passes$/.test(l))).toBe(true)

Expand Down
Loading