Fix landscape reading safe area - #25
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the landscape layout bug where the reading text could extend into the display cutout / inner camera area while the book and chapter controls stayed inside the correct safe boundary.
Root cause
BookControlsBarandChapterControlsBaralready applyWindowInsets.safeDrawingfor horizontal insets, so they avoid landscape cutouts.BibleReadingAreaonly applied status/navigation bar padding and did not consume horizontal safe drawing insets, so in landscape on devices with a side camera/cutout the reading column could draw wider than the controls and text could be hidden.Change
Apply
WindowInsets.safeDrawing.only(WindowInsetsSides.Horizontal)to the reading area container. This makes the right/left edge of the reading area use the same horizontal safe boundary as the book/chapter control rows, while preserving the existing vertical status/navigation handling.Validation
Static diff review only. I could not run Android UI validation from this environment.