Skip to content

Fix landscape reading safe area #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nehemiaharchives merged 2 commits into from
Jul 8, 2026
Merged

Fix landscape reading safe area #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44d374b
Fix landscape reading safe area
nehemiaharchives Jul 8, 2026
d38d6c9
Fix build issue regarding gradle file tracking
nehemiaharchives Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions app/androidApp/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,3 +88,14 @@ android {
targetCompatibility = JavaVersion.VERSION_11
}
}

val cleanStaleMergedComposeAssets = tasks.register<Delete>("cleanStaleMergedComposeAssets") {
delete(layout.buildDirectory.dir("intermediates/assets"))
}

tasks.matching {
it.name.startsWith("merge", ignoreCase = true) &&
it.name.endsWith("Assets", ignoreCase = true)
}.configureEach {
dependsOn(cleanStaleMergedComposeAssets)
}
1 change: 1 addition & 0 deletions app/shared/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,7 @@ tasks.matching {
it.name.contains("Assets", ignoreCase = true)
}.configureEach {
dependsOn(cleanBblAppGeneratedAndroidAssets)
doNotTrackState("Generated Compose resource assets include many embedded pack files; Gradle output snapshotting can exhaust file descriptors.")
}

dependencies {
Expand Down
6 changes: 6 additions & 0 deletions app/shared/src/commonMain/kotlin/org/gnit/bible/app/screens/ReadingScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,18 @@ import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.PaddingValues
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.WindowInsets
import androidx.compose.foundation.layout.WindowInsetsSides
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.navigationBarsPadding
import androidx.compose.foundation.layout.offset
import androidx.compose.foundation.layout.only
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.safeDrawing
import androidx.compose.foundation.layout.statusBarsPadding
import androidx.compose.foundation.layout.windowInsetsPadding
import androidx.compose.foundation.rememberScrollState
import androidx.compose.foundation.verticalScroll
import androidx.compose.material3.MaterialTheme
Expand Down Expand Up @@ -213,6 +218,7 @@ fun BibleReadingArea(
.fillMaxSize()
.statusBarsPadding()
.navigationBarsPadding()
.windowInsetsPadding(WindowInsets.safeDrawing.only(WindowInsetsSides.Horizontal))
.padding(innerPadding)
.padding(top = topChromePadding, bottom = bottomChromePadding)
.clipToBounds()
Expand Down
1 change: 1 addition & 0 deletions gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ kotlin.native.jvmArgs=-Xmx12G
org.gradle.jvmargs=-Xmx12G -Dfile.encoding=UTF-8
org.gradle.configuration-cache=true
org.gradle.caching=true
org.gradle.vfs.watch=false
kotlin.mpp.applyDefaultHierarchyTemplate=false
#Android
android.nonTransitiveRClass=true
Expand Down
Loading