fix(handlers): take the same handler registered twice quietly - #64
Merged
Merged
Conversation
Every app bundles its own copy of the package, so the server's copy and an app's both register the default handlers, and each duplicate logged a warning. A repeat registration with the same id and tagname is now skipped at debug level, keeping the first. Another handler claiming a taken id still warns. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
added
status: review
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
==========================================
+ Coverage 88.76% 88.78% +0.02%
==========================================
Files 39 39
Lines 2760 2765 +5
Branches 567 569 +2
==========================================
+ Hits 2450 2455 +5
Misses 303 303
Partials 7 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every app bundles its own copy of the package, so on 36 the server's copy and an app's (nextcloud/assistant#670) both register the default handlers, and each duplicate logs
Handler with id images is already registered.registerHandler()now skips a registration with the same id andtagnameat debug level, keeping the first. Another handler claiming a taken id still warns.Covered by unit tests, not checked on a real page with two copies.
👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.