Skip to content

fix(SchemaChecker): silence reports from db:add-missing-indices - #64696

Draft
Antreesy wants to merge 3 commits into
masterfrom
fix/6405/schema-check-p3
Draft

Antreesy wants to merge 3 commits into
masterfrom
fix/6405/schema-check-p3

Conversation

@Antreesy

@Antreesy Antreesy commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • command is not mandatory to run, therefore checks should not be reported as blocking
  • example:
    • oc_mail_trusted_senders: missing index 'mail_trusted_senders_type'
    • oc_mail_trusted_senders: unexpected index 'mail_trusted_senders_idx'

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

- command is not mandatory to run, therefore checks should not be reported as blocking
- example:
  - oc_mail_trusted_senders: missing index 'mail_trusted_senders_type'
  - oc_mail_trusted_senders: unexpected index 'mail_trusted_senders_idx'

Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
- MySQL and MariaDB silently drop a literal DEFAULT clause on TEXT/BLOB columns. Migrations that declare such a default are a false-positive findings.
- example:
  - oc_flow_checks: column 'class' differs in: default

Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
- Migrator::getDiff() rewrites any STRING column longer than 4000 characters to TEXT for consistency
- SchemaChecker replays the same migrations for expected schema, but without going through that rewrite, reporting false positive finding.
- example:
  - oc_bookmarks: column 'url' differs in: type

Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
Antreesy force-pushed the fix/6405/schema-check-p3 branch 2 times, most recently from 7f5ce95 to 208449f Compare September 23, 2026 22:03

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants