Skip to content

feat(core): restyle two-factor selection and challenge pages - #64755

Open
skjnldsv wants to merge 2 commits into
feature/2fa-challenge-uxfrom
feature/2fa-restyle
Open

skjnldsv wants to merge 2 commits into
feature/2fa-challenge-uxfrom
feature/2fa-restyle

Conversation

@skjnldsv

@skjnldsv skjnldsv commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

Summary

The design looked old and always bothered me 🙈

TOTP PR: nextcloud/twofactor_totp#1858
Notifications PR: nextcloud/twofactor_nextcloud_notification#1538

Screenshots

Before After
2026-09-25_10-53 2026-09-25_10-44
2026-09-25_10-52 2026-09-25_10-48_1
2026-09-25_10-52_1 2026-09-25_10-55
2026-09-25_10-52_2 2026-09-25_10-48

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@skjnldsv
skjnldsv added this pull request to stack #64756 September 25, 2026 08:34
@skjnldsv
skjnldsv force-pushed the feature/2fa-restyle branch 4 times, most recently from 659a971 to 6bc30b2 Compare September 25, 2026 08:46
Provider tiles become list rows with an icon chip, description in
maxcontrast and a chevron, with hover and visible focus styles.
Secondary actions (another method, backup code, cancel) are grouped in
one block under a divider with button-like hit areas. The code input
and submit button get a larger, full-width style shared through
.two-factor-code-input and .two-factor-submit, and the backup code
input uses autocomplete="one-time-code".

The setup selection and setup challenge pages use the same classes.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>

@susnux susnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI looks good

@susnux
susnux requested a review from kra-mo September 25, 2026 09:34
@skjnldsv
skjnldsv requested review from nimishavijay and removed request for kra-mo September 25, 2026 09:52

@kra-mo kra-mo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely an improvement :)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants