feat: show a loading indicator while waiting for approval - #1538
Merged
Merged
Conversation
Show NcLoadingIcon under the text while polling, use it instead of icon-loading-small while verifying, and drop the spinner from the rejected state. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
feature/challenge-loading-indicator
branch
from
September 25, 2026 09:00
fb70700 to
9bbc4ec
Compare
Assisted-by: ClaudeCode:claude-opus-5.5 Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
feature/challenge-loading-indicator
branch
from
September 25, 2026 10:12
9bbc4ec to
f8a096c
Compare
Member
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Member
|
Adjusted the text a bit and made it bigger, so users don't get distracted by the loading spinner and wait for something: |
nickvergessen
approved these changes
Sep 25, 2026
Member
Author
Noooo, that's out of place now... Check the server pr ... |
Member
Author
|
It's also not following title hierarchy rules... 😅 |
Member
|
It's not a title, but all good. I will recheck the UI once server PRs are all done |
Member
Author
Yes, precisely. A paragraph being as thick and big as the title above raises concerns :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to nextcloud/server#64755 (2FA pages restyle)
👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.