fix(Sharing): Fix recipient IDs on 32-bits - #64867
Merged
Merged
Conversation
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
requested review from
CarlSchwan and
salmart-dev
and removed request for
a team
September 28, 2026 12:16
Member
Author
|
/backport to stable35 |
susnux
approved these changes
Sep 28, 2026
Contributor
|
Makes sense - lets see if CI agrees |
come-nc
approved these changes
Sep 28, 2026
Member
Author
|
The one failing 32-bit test is unrelated to these changes. |
Antreesy
reviewed
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found this failure only by changing unrelated code, which triggered the 32-bits CI: https://github.com/nextcloud/server/actions/runs/36396612438/job/108867999080?pr=64733. Since Unified Sharing already had two issues in 32-bits now, I'm opting for enabling the 32-bits CI by default for any changes to the core logic of Unified Sharing.