Repository navigation
test(cache): expand HomeCache size behavior coverage - #65144
Open
joshtrichards wants to merge 3 commits into
Open
joshtrichards wants to merge 3 commits into
joshtrichards wants to merge 3 commits into
Conversation
The existing tests checked `files` folder size calculations, but did not verify that the root also reports the recalculated `files`-folder size. One test's comment also referred to unknown sizes that were not present in its fixture. - Assert the recalculated `files` size and the root's reported size. - Insert a root-level file to show that it does not affect the root's reported size. - Remove unused fixture data and redundant cleanup. Assisted-by: Copilot:gpt-6-luna Signed-off-by: Josh <josh.t.richards@gmail.com>
The HomeCache size-calculation behavior for `files_trashbin` and `files_versions` was not covered. Add data-driven tests verifying that known-size children contribute to each folder's calculated size while children with unknown sizes are ignored. Assisted-by: Copilot:gpt-6-luna Signed-off-by: Josh <josh.t.richards@gmail.com>
The slash root alias had a separate HomeCache code path from the empty root path, but its no-op size calculation and reported size were not directly tested. Verify that calculating `/` returns zero and reading `/` reports the size of the `files` folder. Assisted-by: Copilot:gpt-6-luna Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
requested review from
Altahrim,
icewind1991,
leftybournes and
salmart-dev
and removed request for
a team
October 5, 2026 14:46
joshtrichards
added
2. developing
joshtrichards
added
3. to review
icewind1991
approved these changes
Oct 8, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #Summary
Expand
HomeCacheTestcoverage for home-storage-specific size reporting.The existing tests checked
filesfolder size calculations, but did not verify that the root reports the recalculatedfiles-folder size too. They also did not cover the special-path behavior forfiles_trashbin,files_versions, or the/root alias. One test comment referred to unknown sizes that were not present in its fixture.Changes:
filesignores children with unknown sizes and that the root reports the resultingfilessize.files_trashbinandfiles_versions./root alias reports thefilesfolder size and that calculating/is a no-op.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)