Skip to content

test(cache): expand HomeCache size behavior coverage #65144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshtrichards wants to merge 3 commits into
base: master
Choose a base branch
from
Open

test(cache): expand HomeCache size behavior coverage #65144

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
36f224b
test(cache): clarify and strengthen home cache size coverage
joshtrichards Oct 5, 2026
7850da8
test(cache): cover home special-folder size handling
joshtrichards Oct 5, 2026
f06a22c
test(cache): cover slash root alias behavior
joshtrichards Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 64 additions & 21 deletions tests/lib/Files/Cache/HomeCacheTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ public function getUID(): string {
}
}

/**
* Tests home-storage-specific cache behavior, with a current focus on size reporting.
*/
#[Group('DB')]
class HomeCacheTest extends TestCase {
private Home $storage;
Expand All @@ -53,11 +56,10 @@ protected function setUp(): void {
}

/**
* Tests that the root and files folder size calculation ignores the subdirs
* that have an unknown size. This makes sure that quota calculation still
* works as it's based on the "files" folder size.
* The files folder size must ignore children with unknown sizes, and the root
* must report the files folder size.
*/
public function testRootFolderSizeIgnoresUnknownUpdate(): void {
public function testFilesFolderSizeIgnoresUnknownChildSizes(): void {
$dir1 = 'files/knownsize';
$dir2 = 'files/unknownsize';
$fileData = [];
Expand All @@ -75,43 +77,84 @@ public function testRootFolderSizeIgnoresUnknownUpdate(): void {
$this->assertTrue($this->cache->inCache($dir1));
$this->assertTrue($this->cache->inCache($dir2));

// check that files and root size ignored the unknown sizes
$this->assertEquals(1000, $this->cache->calculateFolderSize('files'));
$this->assertSame(1000, $this->cache->calculateFolderSize('files'));
$this->assertSame(1000, $this->cache->get('files')['size']);
$this->assertSame(1000, $this->cache->get('')['size']);

// clean up
// Removing the root also removes its descendants.
$this->cache->remove('');
$this->cache->remove('files');
$this->cache->remove($dir1);
$this->cache->remove($dir2);

$this->assertFalse($this->cache->inCache(''));
$this->assertFalse($this->cache->inCache('files'));
$this->assertFalse($this->cache->inCache($dir1));
$this->assertFalse($this->cache->inCache($dir2));
}

public function testRootFolderSizeIsFilesSize(): void {
/**
* The root reports the files folder size, not the stored root size or the
* size of other entries directly under the root.
*/
public function testRootFolderSizeMatchesFilesFolderSize(): void {
$dir1 = 'files';
$afile = 'test.txt';
$fileData = [];
$fileData[''] = ['size' => 1500, 'mtime' => 20, 'mimetype' => 'httpd/unix-directory'];
$fileData[$dir1] = ['size' => 1000, 'mtime' => 20, 'mimetype' => 'httpd/unix-directory'];
$fileData[$afile] = ['size' => 500, 'mtime' => 20];
$fileData['test.txt'] = ['size' => 500, 'mtime' => 20, 'mimetype' => 'text/plain'];

$this->cache->put('', $fileData['']);
$this->cache->put($dir1, $fileData[$dir1]);
$this->cache->put('test.txt', $fileData['test.txt']);

$this->assertTrue($this->cache->inCache($dir1));
$this->assertTrue($this->cache->inCache('test.txt'));

// check that root size ignored the unknown sizes
$data = $this->cache->get('files');
$this->assertEquals(1000, $data['size']);
$data = $this->cache->get('');
$this->assertEquals(1000, $data['size']);
$this->assertSame(1000, $this->cache->get('files')['size']);
$this->assertSame(1000, $this->cache->get('')['size']);

// clean up
// Removing the root also removes its descendants.
$this->cache->remove('');
$this->cache->remove($dir1);

$this->assertFalse($this->cache->inCache(''));
$this->assertFalse($this->cache->inCache($dir1));
$this->assertFalse($this->cache->inCache('test.txt'));
}

public static function specialFolderPathsDataProvider(): array {
return [
['files_trashbin'],
['files_versions'],
];
}

#[\PHPUnit\Framework\Attributes\DataProvider('specialFolderPathsDataProvider')]
public function testSpecialFolderSizeIgnoresUnknownChildSizes(string $path): void {
$knownSizePath = $path . '/knownsize';
$unknownSizePath = $path . '/unknownsize';

$this->cache->put('', ['size' => 0, 'mtime' => 20, 'mimetype' => 'httpd/unix-directory']);
$this->cache->put($path, ['size' => -1, 'mtime' => 20, 'mimetype' => 'httpd/unix-directory']);
$this->cache->put($knownSizePath, ['size' => 1000, 'mtime' => 20, 'mimetype' => 'httpd/unix-directory']);
$this->cache->put($unknownSizePath, ['size' => -1, 'mtime' => 25, 'mimetype' => 'httpd/unix-directory']);

$this->assertSame(1000, $this->cache->calculateFolderSize($path));
$this->assertSame(1000, $this->cache->get($path)['size']);

$this->cache->remove('');

$this->assertFalse($this->cache->inCache($path));
$this->assertFalse($this->cache->inCache($knownSizePath));
$this->assertFalse($this->cache->inCache($unknownSizePath));
}

public function testSlashRootAliasUsesFilesFolderSize(): void {
$this->cache->put('', ['size' => 1500, 'mtime' => 20, 'mimetype' => 'httpd/unix-directory']);
$this->cache->put('files', ['size' => 1000, 'mtime' => 20, 'mimetype' => 'httpd/unix-directory']);

$this->assertSame(0, $this->cache->calculateFolderSize('/'));
$this->assertSame(1000, $this->cache->get('/')['size']);

$this->cache->remove('');

$this->assertFalse($this->cache->inCache(''));
$this->assertFalse($this->cache->inCache('files'));
}
}
Loading