Skip to content

fix: comments follow-ups - #9252

Merged
mejo- merged 9 commits into
mainfrom
fix/comments_followups
Sep 28, 2026
Merged

fix: comments follow-ups#9252
mejo- merged 9 commits into
mainfrom
fix/comments_followups

Conversation

@mejo-

@mejo- mejo- commented Sep 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

馃摑 Summary

Best to be reviewed commit by commit.

  • fix(comments): fix background color for selected comment reference
  • fix(comments): delete empty comment when closing bubble
  • chore(comments): move reused string into const
  • fix(comments): add comment/footnote at end of selection range. Fixes: Inline comment on selected text - not working on first comment or replacing selection聽#9257
  • fix(comments): fix guest user extraction from Markdown
  • fix(annotations): keep undo history intact on cleanup
  • fix(comments): better comments navigation UX

Screenshots

Before After
image image

馃弫 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

馃 AI (if applicable)

  • The content of this PR was partly generated using AI tools
  • The AI-generated content was reviewed, comprehended and tested by a human

@mejo- mejo- self-assigned this Sep 24, 2026
@mejo- mejo- added the bug Something isn't working label Sep 24, 2026
@mejo-
mejo- requested a review from silverkszlo as a code owner September 24, 2026 14:39
@github-project-automation github-project-automation Bot moved this to 馃Л Planning evaluation (don't pick) in 馃摑 Productivity team Sep 24, 2026
@mejo- mejo- moved this from 馃Л Planning evaluation (don't pick) to 馃憖 In review in 馃摑 Productivity team Sep 24, 2026
@mejo- mejo- mentioned this pull request Sep 25, 2026
Closed
@mejo-
mejo- force-pushed the fix/comments_followups branch from 0944b44 to 32bd442 Compare September 25, 2026 14:17
max-nextcloud
max-nextcloud approved these changes Sep 27, 2026
View reviewed changes

@max-nextcloud max-nextcloud left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling these. Looks great! 鉂わ笍

I have a few minor comments but nothing that would block a merge.

Comment thread src/plugins/referenceHelpers.ts Outdated
Comment thread src/nodes/CommentReference.ts Outdated
@mejo-

mejo- commented Sep 28, 2026

Copy link
Copy Markdown
Member Author

/backport to stable35

@mejo-
fix(comments): fix background color for selected comment reference
59340d9 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
fix(comments): delete empty comment when closing bubble
0735214 
Insert comment and then escape now removes the empty comment reference.

Signed-off-by: Jonas <jonas@freesources.org>
Assisted-by: OpenCode:claude-fable-5
@mejo-
chore(comments): move reused string into const
b7bd071 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
fix(comments): add comment/footnote at end of selection range
1fdb749 
Signed-off-by: Jonas <jonas@freesources.org>
Assisted-by: OpenCode:claude-fable-5
@mejo-
fix(comments): fix guest user extraction from Markdown
4ac4a56 
Signed-off-by: Jonas <jonas@freesources.org>
Assisted-by: OpenCode:claude-fable-5
@mejo-
fix(annotations): keep undo history intact on cleanup
4fb5546 
The cleanup plugins for comments and footnotes appended transactions
marked as `addToHistory: alse`. ProseeMirror applies the user's
transaction and the appended ones as one batch and y-prosemirror trakes
the `addToHistory` flag of the last transaction in that batch. This led
to broken undo history.

Signed-off-by: Jonas <jonas@freesources.org>
Assisted-by: OpenCode:claude-fable-5.1
@mejo-
fix(comments): better comments navigation UX
6028e42 
* Header: "< Comment 3 of 4 >" instead of "Comments ^ 3 / 4 v"
* Allow to navigate comments with keyboard shortcuts

Signed-off-by: Jonas <jonas@freesources.org>
Assisted-by: OpenCode:claude-fable-5.1
@mejo-
chore(comments): add helpers for comment draft in session storage
64adbc5 
Signed-off-by: Jonas <jonas@freesources.org>
Assisted-by: OpenCode:claude-opus-5.5
@mejo-
refactor(comments): insert annotation independant of reference position
a69d7db 
Signed-off-by: Jonas <jonas@freesources.org>
Assisted-by: OpenCode:claude-fable-5.1
@mejo-
mejo- force-pushed the fix/comments_followups branch from 32bd442 to a69d7db Compare September 28, 2026 12:41
@mejo-
mejo- merged commit 39e35be into main Sep 28, 2026
64 checks passed
@mejo-
mejo- deleted the fix/comments_followups branch September 28, 2026 13:07
@github-project-automation github-project-automation Bot moved this from 馃憖 In review to 鈽戯笍 Done in 馃摑 Productivity team Sep 28, 2026
@backportbot backportbot Bot mentioned this pull request Sep 28, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@max-nextcloud max-nextcloud max-nextcloud approved these changes
@silverkszlo silverkszlo Awaiting requested review from silverkszlo silverkszlo is a code owner

Assignees

@mejo- mejo-

Labels

3. to review bug Something isn't working

Projects

馃摑 Productivity team
Status: 鈽戯笍 Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inline comment on selected text - not working on first comment or replacing selection

2 participants

@mejo- @max-nextcloud