feat(prompt-templates): add 11 HyperFrames video prompts + media generation README section#227
feat(prompt-templates): add 11 HyperFrames video prompts + media generation README section#227
Conversation
There was a problem hiding this comment.
π‘ Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 59dd3abf14
βΉοΈ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with π.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
lefarcen
left a comment
There was a problem hiding this comment.
Hey @pftom! π The 11 HyperFrames templates themselves look excellent β clean JSON schemas, comprehensive prompts with scene-by-scene timing + GSAP eases, all validated by the daemon's validateTemplate, real HeyGen catalog thumbnails (HTTP 200), proper Apache-2.0 attribution. The Media generation README section is also well-written and fits naturally between Visual directions and Beyond chat.
However β this PR has severe scope drift. The diff shows 151 files changed, 8527 deletions, including:
CRITICAL: Unrelated deletions that belong in separate PRs
1. Design system mass deletion (57 files)
- Removes
design-systems/{agentic,ant,application,artistic,bento,bold,brutalism,...}/DESIGN.mdβ 57 design skill DESIGN.md files (~71 lines each) - Changes count from 129 β 72 systems in README
- Why this is blocking: These deletions are unrelated to HyperFrames. If they're intentional cleanup (e.g., removing low-quality imported skills per #XYZ discussion), that belongs in a separate PR with its own rationale. If accidental, they need to be restored.
2. Japanese locale deletion (639 lines)
- Deletes
apps/web/src/i18n/locales/ja.tsentirely - Removes
README.ja-JP.mdlink from main README language switcher - Why this is blocking: Locale removal is a product decision that needs maintainer sign-off + community notice. Bundling it with a template PR hides the impact.
3. Kiro CLI removal
- Removes Kiro from CLI list (11 β 10), adapter references, test coverage
- Why this is blocking: CLI adapter removal affects user-facing feature parity and should be discussed/documented separately (deprecation notice, migration guide if Kiro users exist).
4. Infrastructure gutting
- Deletes
apps/daemon/src/app-version.ts+ tests (app version tracking) - Removes
.github/workflows/release-stable.yml(406 lines),scripts/release-stable.ts(141 lines),CHANGELOG.md(192 lines) - Deletes
tools/pack/src/win.ts(1194 lines β entire Windows packaging) - Removes
TRANSLATIONS.md(228 lines) - Why this is blocking: These are major CI/CD and packaging changes. Each deserves its own PR with rollout plan + stakeholder review.
5. Seedance Three Kingdoms template deletion (7 templates)
- Removes
prompt-templates/video/{seedance-three-kingdoms-guanyu-slaying-yanliang, lyubu-yuanmen-archery, zhaoyun-cradle-escape}.json+.mp4artifacts + screenshots - Also removes
game-ui-ancient-china-open-world-mmo-hud.json, choreography breakdowns, etc. - Why this is blocking: If these were placeholder/test templates β explain in commit message. If they're real user-facing templates β deletion needs justification (licensing issue? quality bar?).
What should happen
Option A (recommended): Revert all unrelated changes, keep only HyperFrames additions
git rebase -i mainand drop/edit commits that touch non-HyperFrames files- Keep only:
- 11 new
prompt-templates/video/hyperframes-*.jsonfiles - README.md changes: new Media generation section + At a glance table row
- Any HyperFrames-specific daemon/web wiring (if needed β currently
hyperframes-htmlmodel already exists perapps/web/src/media/models.ts:347)
- 11 new
- Force-push cleaned branch
Option B: Split into multiple PRs
- This PR (#227) β HyperFrames templates + README only
- New PR β Design system cleanup with rationale ("Removing 57 low-usage imported skills per maintainer discussion in #XYZ")
- New PR β Locale consolidation ("Deprecating ja/de locales due to unmaintained translations")
- New PR β Kiro CLI removal + deprecation notice
- New PR β CI/packaging refactor ("Simplify release workflow + remove Windows native packaging")
- New PR β Seedance Three Kingdoms template removal with explanation
Option C: If all changes are intentional as one "big cleanup" commit
- Retitle PR to reflect actual scope:
refactor: remove 57 design skills, ja/de locales, Kiro CLI, Windows packaging; add 11 HyperFrames templates - Add detailed commit body explaining:
- Why each deletion (unmaintained? licensing? quality bar?)
- Impact on existing users (e.g., "Kiro CLI had 0 active users per telemetry")
- Rollback plan if users complain
- Get explicit maintainer approval before merge (this is not a routine template addition anymore)
PR #98 precedent
This mirrors PR #98's scope-drift pattern ("OneShot Design workflow launcher" that deleted 5 locales + 7 docs + 6 skills). That PR was eventually closed after repeated "still production-ready" reviews couldn't address the core issue: major decisions (removing existing surfaces) bundled with a feature PR.
Why scope drift breaks the review process:
- Reviewers focus on the stated feature (HyperFrames templates) β miss the deletions
- Deletions that need stakeholder discussion get auto-merged without visibility
- Rollbacks become messy (can't revert just the bad part without losing the good part)
The HyperFrames part is LGTM π
Once the scope is cleaned up, I'd love to approve the HyperFrames additions. They're production-ready:
- β
All 11 JSON schemas pass
validateTemplate(id, surface, title, prompt β₯ 20 chars, source.repo + license) - β
Filenames match
idβ daemon detail lookups work - β
model: "hyperframes-html"matchesVIDEO_MODELSentry - β Preview URLs return HTTP 200 (HeyGen CDN)
- β Prompt bodies are comprehensive (scene timing, GSAP eases, palette, non-negotiables)
- β README insertion point is natural (between Visual directions and Beyond chat)
- β No security issues (all external URLs are HeyGen/Cloudflare CDN, no user-controlled injection)
Minor suggestions (non-blocking, for future iterations):
- P3: Consider adding a
durationfield to each template's JSON (currently only in prompt body) so the gallery can show "5s" / "30s" badges without parsing prompts - P3: README says "83 ready-to-replicate prompts" (36 image + 36 Seedance + 11 HyperFrames) β if the 7 Seedance Three Kingdoms deletions are intentional, update the count to 76
Action needed: Please clarify intent for the 8500-line deletion, then either revert unrelated changes or retitle + get maintainer sign-off. Happy to re-review once scope is clean! π
β¦media generation in README Adds eleven `hyperframes-*` prompt templates under `prompt-templates/video/`, each one a concrete brief with scene-by-scene timing, GSAP eases, palette, and the HyperFrames non-negotiables (deterministic, paused timelines, entrance-only motion, lint/inspect commands). Archetypes covered: - minimal product reveal (5s, 16:9) - SaaS product promo (30s, 16:9, Linear/ClickUp-style) - TikTok karaoke talking-head (9:16, TTS + word-synced captions) - brand sizzle reel (30s, beat-synced kinetic typography) - animated bar-chart race (NYT-style data infographic) - Apple-style flight map route (origin β destination) - 4s cinematic logo outro - $0 β $10K money counter hype (9:16) - 3-phone app showcase - 9:16 social overlay stack (X Β· Reddit Β· Spotify Β· Instagram) - 15s website-to-video pipeline Each template uses `model: "hyperframes-html"`, real catalog-block thumbnails from HeyGen's CDN as previewImageUrl, and source attribution to `heygen-com/hyperframes` (Apache-2.0). README also gets a new **Media generation** section between *Visual directions* and *Beyond chat*, plus a new row in the *At a glance* table. The section documents the three model families currently surfaced as templates (gpt-image-2, Seedance 2.0, HyperFrames) with example galleries β gpt-image-2 thumbnails, Seedance MP4-linked thumbnails, and the 11 HyperFrames tiles β and notes the wider model coverage (Kling, Veo, Sora, MiniMax, Suno, Udio, Lyria, TTS) already wired in `VIDEO_MODELS` / `AUDIO_MODELS_BY_KIND` and open for community templates.
Adds German titles/summaries for the 11 new hyperframes-* video templates plus the Product/Marketing/Data/Travel/Branding/Short Form categories and hyperframes/title-card/sizzle/etc. tags they introduce, so the German sync guarantees enforced by apps/web/src/i18n/content.test.ts hold.
β¦bump counts to 93 (43 + 39 + 11) Mirrors the English Media generation row + section into the four locale READMEs (README.de.md, README.ja-JP.md, README.ko.md, README.zh-CN.md), translating prose / table headers / captions while keeping the gpt-image-2, Seedance MP4, and HyperFrames catalog-block thumbnails identical across all five locales so the galleries render the same images. Counts updated to reflect current main (after rebase): 43 gpt-image-2 + 39 Seedance + 11 HyperFrames = 93 prompts total. The English README's At-a-glance row, intro paragraph, and gallery sub-headers now read "sample of 43" / "sample of 39" / "11 ready-to-replicate templates" β locales follow. Resolves the Codex review's German-i18n flag end-to-end: README copy is in sync, and the German content map (DE_PROMPT_TEMPLATE_*) was already extended in the prior commit on this branch.
|
Pushed
Counts in all five READMEs now read 93 prompts (43 gpt-image-2 + 39 Seedance + 11 HyperFrames) β accurate against current Re: @chatgpt-codex-connector P1 β German i18n sync β
Addressed in Re: @lefarcen review β scope is clean
|
|
To use Codex here, create a Codex account and connect to github. |
lefarcen
left a comment
There was a problem hiding this comment.
Perfect! π Scope is now clean β 17 files, 666 additions, 0 deletions. All CRITICAL issues from the first review are resolved:
β
All 57 design system deletions: reverted
β
Japanese locale deletion: reverted
β
Kiro CLI removal: reverted
β
Infrastructure gutting (Windows packaging, release workflows, CHANGELOG.md): reverted
β
Seedance Three Kingdoms template deletions: reverted
What remains (exactly as the PR title promised):
- 11 new HyperFrames video prompt templates (all validate clean)
- Media generation section in README.md (+ 4 localized READMEs)
- German i18n for the new templates
Template quality β production-ready:
- All 11 JSONs pass
validateTemplateshape - Filenames match
id(daemon detail lookups work) - Preview URLs return HTTP 200
- Prompts comprehensive (scene timing, GSAP eases, HyperFrames non-negotiables)
- Proper Apache-2.0 attribution to heygen-com/hyperframes
LGTM for merge! π
Summary
hyperframes-*prompt templates underprompt-templates/video/, each withmodel: "hyperframes-html", scene-by-scene briefs, real HeyGen catalog-block thumbnails as previews, andheygen-com/hyperframes(Apache-2.0) attribution.README.md(between Visual directions and Beyond chat), with three example galleries: 5-tile gpt-image-2 grid, 5-tile Seedance grid where each thumbnail links to the actual rendered MP4, and 11-tile HyperFrames grid where each tile links to the template JSON.Templates added
hyperframes-product-reveal-minimalhyperframes-saas-product-promo-30shyperframes-tiktok-karaoke-talking-headhyperframes-brand-sizzle-reelhyperframes-data-bar-chart-racehyperframes-flight-map-routehyperframes-logo-outro-cinematichyperframes-money-counter-hypehyperframes-app-showcase-three-phoneshyperframes-social-overlay-stackhyperframes-website-to-video-promoEach prompt body specifies the HyperFrames non-negotiables (deterministic only, all timelines
paused: true, entrance-only animations, norepeat: -1, transitions handle scene exits, runlint/inspect/validatebefore render) so the agent generates a composition that lints clean.Why HyperFrames
heygen-com/hyperframesis HeyGen's open-source agent-native HTMLβMP4 framework β agents write HTML + CSS + GSAP, HF renders deterministically via headless Chrome + FFmpeg. OD already has thehyperframes-htmlmodel wired inVIDEO_MODELSand theskills/hyperframes/skill that teaches the agent the contract; the templates close the loop by giving users one-click starting points (product reveal, sizzle reel, data chart, social overlays, β¦) that map directly to the HF catalog blocks.Validation
validateTemplateshape (id, surface, title, prompt β₯ 20 chars, source.repo + source.license).idsoGET /api/prompt-templates/:surface/:iddetail lookups resolve.Test plan
pnpm tools-dev run webβ open the Video templates tab in the entry view, confirm 11 new HyperFrames cards appear alphabetically with thumbnails loaded.hyperframes-htmlmodel preselected.hyperframes-product-reveal-minimal) end-to-end and confirm a.mp4lands as a project chip.