Conversation
lefarcen
left a comment
There was a problem hiding this comment.
Hey @mrcfps! Clean optimization PR β simple + effective. π
The .next/cache exclusion makes perfect sense (build artifacts shouldn't ship). Compression switch is safe for Electron Builder: maximum = 7zip on macOS, NSIS built-in on Windows. Slower build, smaller artifact β the right trade-off for release builds.
Lens A (code correctness):
No runtime impact. Electron extracts the bundle before launch, so startup time stays the same.
Lens B (reasoning completeness):
Validation shows 749 MB β 449 MB for macOS. Windows artifact size not measured, but I'd expect ~30-40% reduction there too (similar to macOS). Build-time trade-off (maybe +1-2 min for compression) is acceptable for release builds β we're not compressing on every dev build.
Minor observation (non-blocking):
- The PR tested macOS artifact size. When you merge this, keep an eye on the first Windows release build to confirm similar compression gains there (you can eyeball the GitHub Actions artifact or check locally).
LGTM for merge. π
Summary
Validation
Notes
pnpm testwas run; existing unrelated German i18n metadata coverage failures remain inapps/web/src/i18n/content.test.ts.