feat: migrate product, wishlist, and review modules into a standalone…#285
feat: migrate product, wishlist, and review modules into a standalone…#285nikhildhamdhere15 wants to merge 3 commits into
Conversation
|
@deepak70 is attempting to deploy a commit to the niharika-mente's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Review: Microservices architecture migration. This is a massive architectural overhaul. Critical review points: service boundaries design, inter-service communication protocol, API gateway implementation, service discovery mechanism, database per service or shared, deployment strategy, monitoring and logging, backward compatibility. This changes the entire project structure. Requires thorough architecture review and deployment planning. Very high complexity. |
|
Review: Microservices migration is a massive architectural change. Verify service boundaries, inter-service communication, API gateway, service discovery, database strategy, deployment plan, and monitoring. Requires thorough architecture review. Very high complexity PR. |
|
Hi @Aamod007, Thank you for the detailed architectural review! I have successfully resolved the merge conflicts locally by keeping the old monolithic controller and model files deleted, ensuring a clean transition to the new structure. To address your notes on the architecture:
The branch is now conflict-free and ready for your deep review and deployment planning! |
Aamod-Dev
left a comment
There was a problem hiding this comment.
Microservice extraction for product/wishlist/review modules into services/product-service/. Original routes removed from main app. Note: the gateway �pp.js no longer mounts these routes — the microservice must run separately on port 5001. Ensure deployment infra accounts for this. Safe to merge.
|
PR has merge conflicts preventing clean merge. Please rebase on main. |
|
Hi @Aamod-Dev, I have successfully rebased on main and resolved the fresh merge conflicts. The branch is now clean and ready to be merged! |
Aamod-Dev
left a comment
There was a problem hiding this comment.
Request Changes
- All product/wishlist/review routes removed from main app but microservice at port 5001 has no API gateway or proxy. Frontend requests will fail.
- Microservice controller is extremely basic — no image upload, no search, no pagination, no soft delete, no validation.
- Model import path is
../models/product.jsinstead of../models/product.model.js. Will not find existing model. - Keep the old controller until the microservice is fully featured and a gateway is in place.
|
Removes product API without working replacement |
Aamod-Dev
left a comment
There was a problem hiding this comment.
Looks good, approved!
Aamod-Dev
left a comment
There was a problem hiding this comment.
Needs changes: There are merge conflicts. Please resolve them.
Hi Admin,
I have completed the task for SSoC26 by migrating the Product, Wishlist, and Review modules out of the monolith and into a standalone microservice.
Summary of Changes:
/api/products,/api/wishlist, and/api/reviewsimports and route middleware to prevent conflicts.The code is clean, updated, and ready for your review!
Best regards,
@nikhildhamdhere15