Fix/review filter reset#402
Merged
Aamod-Dev merged 5 commits intoJun 23, 2026
Merged
Conversation
|
Someone is attempting to deploy a commit to the niharika-mente's projects Team on Vercel. A member of the Team first needs to authorize it. |
Aamod-Dev
previously approved these changes
Jun 22, 2026
Aamod-Dev
left a comment
Aamod-Dev
left a comment
Collaborator
There was a problem hiding this comment.
Clean frontend-only fix. Disabling filter/sort controls during search eliminates the misleading UX where users expect them to work with search results. Resetting review filters on productId change is a nice bug fix too. LGTM.
Aamod-Dev
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disables sorting and filtering controls while a search query is active.
Changes
isDisabledprop toFilterPanel.Why
The search API currently ignores sort and filter parameters. Disabling these controls during search prevents misleading behavior where users expect the controls to affect search results when they do not.
closes #359