fix(ci): work around npm optional deps bug in FRONTEND builds#403
Merged
Conversation
…RONTEND npm ci fails on Linux CI runners because of npm bug #4828 where cross-platform optional dependencies (like @rollup/rollup-linux-x64-gnu) are not installed correctly from a lockfile generated on Windows. Switching to npm install for FRONTEND dependencies in both CI jobs avoids this issue while the lockfile can be regenerated natively. Also adds npm caching to the e2e-tests job for faster installs.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI's \�uild-and-lint\ job fails on every PR with:
\
Error: Cannot find module @rollup/rollup-linux-x64-gnu.
npm has a bug related to optional dependencies (npm/cli#4828).
\\
The \FRONTEND/package-lock.json\ was generated on Windows. When
pm ci\ runs on the Linux CI runner, it doesn't properly install cross-platform optional dependencies due to npm bug #4828.
Fix
pm ci\ to
pm install\ in both CI jobs (the recommended workaround for this npm bug)
Root + BACKEND still use
pm ci\ since they don't have this issue.