Fix/product store response handling#407
Merged
Aamod-Dev merged 6 commits intoJun 23, 2026
Merged
Conversation
|
Someone is attempting to deploy a commit to the niharika-mente's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves error handling in
deleteProductandupdateProductby checkingres.okbefore attempting to parse JSON responses.Changes
res.okvalidation indeleteProduct.res.okvalidation inupdateProduct.res.json()from throwing when the server returns a non-JSON error response.Why
Previously, both functions called
res.json()immediately afterfetch(). If the server returned an HTML error page or another non-JSON response,res.json()would throw aSyntaxError, which was caught and incorrectly reported as a network error. This change preserves the actual request failure information and aligns the behavior with the existing error-handling pattern used elsewhere in the store.closes #350