Repository navigation
Fix unnecessary study plan fetch and 500 when no plan exists - #111
Merged
nilskntl merged 1 commit intoMar 21, 2026
Conversation
- Guard useStudyPlan hook with classData?.examDate so the API call is skipped entirely when no exam date is set on the class - Replace RuntimeException with EntityNotFoundException in StudyPlanService so a missing plan returns HTTP 404 instead of 500 Implements #110 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
3 tasks done
nilskntl
self-requested a review
March 21, 2026 00:28
nilskntl
deleted the
110-fix-unnecessary-study-plan-fetch-and-backend-500-when-no-plan-exists
branch
March 21, 2026 00:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useStudyPlaninClassDetailPage.tsxwithclassData?.examDateso no API call is made when the class has no exam date setRuntimeExceptionwithEntityNotFoundExceptioninStudyPlanServicesoGET /api/classes/{classId}/study-planreturns HTTP 404 (instead of 500) when no plan existsIssue
Closes #110
Generated with Claude Code