Skip to content

Fix unnecessary study plan fetch and 500 when no plan exists #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nilskntl merged 1 commit into from
Mar 21, 2026
Merged

Fix unnecessary study plan fetch and 500 when no plan exists #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions minerva-api/src/main/java/io/minerva/api/service/StudyPlanService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package io.minerva.api.service;

import io.minerva.api.component.CurrentUser;
import io.minerva.api.exceptions.EntityNotFoundException;
import io.minerva.api.exceptions.UnauthorizedException;
import io.minerva.api.model.data.node.Clazz;
import io.minerva.api.model.data.node.StudyPlan;
Expand Down Expand Up @@ -106,7 +107,7 @@ public StudyPlanDto getStudyPlan(UUID classId) {
Clazz clazz = getAuthorizedClass(classId);
StudyPlan plan = studyPlanRepository.findByClassId(classId)
.orElseThrow(
() -> new RuntimeException("No study plan found for this class"));
() -> new EntityNotFoundException("No study plan found for this class"));
return computeDto(clazz, plan);
}

Expand All @@ -126,7 +127,7 @@ public StudyPlanDto updateStudyPlan(UUID classId, UpdateStudyPlanRequestDto requ
Clazz clazz = getAuthorizedClass(classId);
StudyPlan plan = studyPlanRepository.findByClassId(classId)
.orElseThrow(
() -> new RuntimeException("No study plan found for this class"));
() -> new EntityNotFoundException("No study plan found for this class"));

plan.setDailyGoalOverride(request.getDailyGoalOverride());
studyPlanRepository.save(plan);
Expand All @@ -145,7 +146,7 @@ public void deleteStudyPlan(UUID classId) {
getAuthorizedClass(classId);
StudyPlan plan = studyPlanRepository.findByClassId(classId)
.orElseThrow(
() -> new RuntimeException("No study plan found for this class"));
() -> new EntityNotFoundException("No study plan found for this class"));
studyPlanRepository.deleteStudyPlanById(plan.getId());
}

Expand Down
2 changes: 1 addition & 1 deletion minerva-hub/src/pages/app/ClassDetailPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export function ClassDetailPage() {

const {data: classData, isLoading: isLoadingClass} = useClass(id!);
const {data: topics, isLoading: isLoadingTopics} = useTopics(id);
const {data: studyPlan, isError: studyPlanNotFound} = useStudyPlan(id);
const {data: studyPlan, isError: studyPlanNotFound} = useStudyPlan(classData?.examDate ? id : undefined);
const createTopicMutation = useCreateTopic();
const updateTopicMutation = useUpdateTopic();
const deleteTopicMutation = useDeleteTopic();
Expand Down
Loading