Repository navigation
fix(ci): settle card interactions before exact checks - #984
Merged
Merged
Conversation
nocoo
changed the title
nocoo
marked this pull request as ready for review
October 2, 2026 22:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The card-action checks reopened the menu before verifying closure and restored focus, and established an exact scroll baseline while the card entrance animation was still running. Assert the close/focus/reopen states and await the wrapper's actual Animation.finished before constructing the tall-card scroll geometry. All original exact scroll and outside-touch assertions remain unchanged.
Validation on 2026-10-03 at
5a2ee8d1bd485d4ac1f3db0b2c40cd5b529f4058: a fresh isolated full browser run passed 225/225, actionlint and strict focused lint passed, and every enabled current-head check is green in https://github.com/nocoo/zhe/actions/runs/36937846212. Both original commits are retained.Source stable incident: https://github.com/nocoo/zhe/actions/runs/36357254553. The independent Stress workflow remains disabled_manually and AWAITING_SAFE_VERIFICATION; ordinary CI does not certify its recovery. No workflow was enabled and no release tag was created. Post-merge main CI passed at merge commit
906853531c6c3bbccc03f16b83d032e33711fe74: https://github.com/nocoo/zhe/actions/runs/37072624866 (225/225 browser tests). Later independent main changes are separate from this verified merge revision. The disabled Stress workflow remains unverified.