Skip to content

fix(ci): settle card interactions before exact checks #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nocoo merged 2 commits into from
Oct 2, 2026
Merged

fix(ci): settle card interactions before exact checks #984

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a5821d
test: verify card menu interaction states
nocoo Oct 1, 2026
5a2ee8d
test: await card entrance before scroll checks
nocoo Oct 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tests/playwright/card-actions.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,10 @@ for (const collection of ["grid", "list", "github", "x"] as const) {
await page.keyboard.press("ArrowDown");
await expect(menu.getByRole("menuitem").nth(1)).toBeFocused();
await page.keyboard.press("Escape");
await expect(menu).not.toBeVisible();
await expect(more).toBeFocused();
await more.tap();
await expect(menu).toBeVisible();
await page.touchscreen.tap(width - 5, 100);
await expect(menu).not.toBeVisible();
await page.screenshot({ path: `.artifacts/card-actions-${collection}-${width}.png` });
Expand Down Expand Up @@ -208,9 +211,10 @@ test("selection keeps a tall card stationary and Escape exits without scrolling"
const choice = page.getByRole("checkbox", { name: "选择 Tall selection card" });
await expect(choice).toBeVisible();
const overlay = page.locator("label").filter({ has: choice });
const point = await overlay.evaluate((el) => {
const point = await overlay.evaluate(async (el) => {
const wrapper = el.parentElement;
if (!wrapper) throw new Error("Missing selection wrapper");
await Promise.all(wrapper.getAnimations().map((animation) => animation.finished));
wrapper.style.minHeight = "1400px";
let scroller = wrapper.parentElement;
while (scroller && !/(auto|scroll)/.test(getComputedStyle(scroller).overflowY))
Expand Down
Loading