Skip to content

nostr: serialize and deserialize ClientMessage without a Value tree - #1426

Merged
yukibtc merged 1 commit into
masterfrom
client-msg
Aug 5, 2026
Merged

nostr: serialize and deserialize ClientMessage without a Value tree#1426
yukibtc merged 1 commit into
masterfrom
client-msg

Conversation

@yukibtc

@yukibtc yukibtc commented Aug 5, 2026

Copy link
Copy Markdown
Member

Description

Follow-up of the PR #1425, for the ClientMessage.

CC @JSKitty

Checklist

  • I followed the contribution guidelines
  • I updated the relevant CHANGELOG.md (if applicable)
  • I understand and can explain all code in this PR

@yukibtc yukibtc added this to the v0.45 milestone Aug 5, 2026
@yukibtc
yukibtc requested a review from TheAwiteb as a code owner August 5, 2026 08:19
yukibtc added a commit that referenced this pull request Aug 5, 2026
@yukibtc
nostr: serialize and deserialize ClientMessage without a Value tree
6349290 
Follow-up of the PR #1425

Pull-Request: #1426
Signed-off-by: Yuki Kishimoto <yukikishimoto@protonmail.com>
@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

yukibtc added a commit that referenced this pull request Aug 5, 2026
@yukibtc
nostr: serialize and deserialize ClientMessage without a Value tree
e5a9af8 
Follow-up of the PR #1425

Pull-Request: #1426
Signed-off-by: Yuki Kishimoto <yukikishimoto@protonmail.com>
@JSKitty

JSKitty commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

tACK, ran this against my benchmark harness, beautiful results, you beat me to the punch. 😄

Numbers for this PR

Base 25f7bb88 vs the PR, Apple M4, min-of-5 over 50–100k iterations:

operation before after
EVENT as_json (449 B) 1267 ns 506 ns 2.5×
EVENT from_json 2033 ns 1023 ns 2.0×
REQ as_json (117 B) 623 ns 134 ns 4.6×
REQ from_json 1260 ns 509 ns 2.5×

@JSKitty JSKitty mentioned this pull request Aug 5, 2026
Merged
3 tasks
@yukibtc
nostr: serialize and deserialize ClientMessage without a Value tree
331c6a8 
Follow-up of the PR #1425

Pull-Request: #1426
Signed-off-by: Yuki Kishimoto <yukikishimoto@protonmail.com>
@yukibtc
yukibtc merged commit 331c6a8 into master Aug 5, 2026
42 checks passed
TheAwiteb
TheAwiteb reviewed Aug 5, 2026
View reviewed changes
Comment thread nostr/src/message/client.rs
@yukibtc
yukibtc deleted the client-msg branch August 5, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheAwiteb TheAwiteb TheAwiteb left review comments
+1 more reviewer
@JSKitty JSKitty JSKitty approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.45

Development

Successfully merging this pull request may close these issues.

3 participants

@yukibtc @JSKitty @TheAwiteb