Skip to content

nostr: serialize and deserialize ClientMessage without a Value tree #1426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yukibtc merged 1 commit into from
Aug 5, 2026
Merged

nostr: serialize and deserialize ClientMessage without a Value tree #1426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion nostr-sdk/src/local_relay/local/inner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,7 +916,6 @@ impl InnerLocalRelay {
subscription_id,
filter,
initial_message,
..
} => {
if let RateLimiterResponse::Limited =
session.check_query_rate_limit(self.queries_per_minute)
Expand Down
5 changes: 1 addition & 4 deletions nostr-sdk/src/relay/api/sync.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,6 @@ pub(super) async fn sync(
let open_msg: ClientMessage = ClientMessage::NegOpen {
subscription_id: Cow::Borrowed(&sub_id),
filter: Cow::Borrowed(filter),
id_size: None,
initial_message: Cow::Owned(faster_hex::hex_string(&initial_message)),
};
relay.send_msg(open_msg).await?;
Expand Down Expand Up @@ -565,9 +564,7 @@ async fn check_negentropy_support(
}
RelayMessage::Notice(message) => {
if message == "ERROR: negentropy error: negentropy query missing elements" {
// The NEG-OPEN message is sent with 4 elements instead of 5
// If the relay return this error means that is not support new
// negentropy protocol
// The relay expects the deprecated five-element NEG-OPEN format.
return Err(negentropy::Error::UnsupportedProtocolVersion.into());
} else if message.contains("bad msg")
&& (message.contains("unknown cmd")
Expand Down
3 changes: 2 additions & 1 deletion nostr/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
- Remove `EventBuilder::sign_with_keys` and `EventBuilder::sign_with_ctx` (https://github.com/nostrdevkit/nostr/pull/1355)
- Remove `UnsignedEvent::sign_with_keys`, `UnsignedEvent::sign_with_ctx` and `UnsignedEvent::sign_with_aux_rand` (https://github.com/nostrdevkit/nostr/pull/1355)
- Remove `JsonUtil` trait (https://github.com/nostrdevkit/nostr/pull/1365)
- Remove the deprecated `id_size` field from `ClientMessage::NegOpen` https://github.com/nostrdevkit/nostr/pull/1426

### Changed

Expand Down Expand Up @@ -117,7 +118,7 @@
- Optimize event serialization by ~73% (https://github.com/nostrdevkit/nostr/pull/1319)
- Hardware-accelerate SHA-256 where available (https://github.com/nostrdevkit/nostr/pull/1419)
- Reduce allocations and redundant key parsing in the NIP-44 v2 path (https://github.com/nostrdevkit/nostr/pull/1421)
- Serialize and deserialize `RelayMessage` without a `serde_json::Value` tree (https://github.com/nostrdevkit/nostr/pull/1425)
- Serialize and deserialize `RelayMessage` and `ClientMessage` without a `serde_json::Value` tree (https://github.com/nostrdevkit/nostr/pull/1425 and https://github.com/nostrdevkit/nostr/pull/1426)
- Avoid allocating a `String` per generic tag key when serializing and deserializing `Filter` (https://github.com/nostrdevkit/nostr/pull/1427)

### Security
Expand Down
Loading
Loading