fix: repoint licensed-plugin references at nself-org/bundles - #431
Merged
Merged
Conversation
The private licensed-plugin repo was renamed plugins-pro -> bundles (ADR-P6-01). One of these references is functional and the rest are documentation or CI configuration. Functional: - internal/plugin/verify/verify_sbom.go builds GitHub release-asset URLs for SBOM verification from the repo name. CI / tooling: - ci-green-rate.yml and scripts/sync-badges.sh poll the repo by name. sync-badges.sh keeps "plugins-pro" in REPO_NAMES because that is the local checkout directory, and the two arrays are index-aligned. - sdk/go ci.yml private-import guard now blocks BOTH spellings via a single -E pattern. The old module path still resolves through GitHub's rename redirect, so dropping it would have opened the leak this guard exists to close. Data: - internal/plugin/count/counts.json re-vendored from the regenerated artifact. Counts are unchanged (129/127 free, 46/46 licensed, 171 advertised); only sources.pro.repo and the two source blob SHAs move. The generator itself is fixed in nself-org/plugins. Plus 14 wiki pages and the count fixture. counts.json is generated and was not hand-edited.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-through on the plugins-pro -> bundles rename (ADR-P6-01), P6-E4-W3-S3-T7.
Functional change:
internal/plugin/verify/verify_sbom.goconstructs GitHub release-asset URLs from the repo name, so SBOM verification was pointing at the pre-rename path.CI / tooling:
ci-green-rate.ymlandscripts/sync-badges.shpoll by repo name.sync-badges.shdeliberately keepsplugins-proinREPO_NAMES— that is the local checkout directory name, and the two arrays are index-aligned.Guard widened, not moved: the sdk/go private-import check now blocks
nself-org/(bundles|plugins-pro)with one-Epattern. The old module path still resolves through GitHub's rename redirect, so simply renaming the pattern would have let a stale import through the check that exists to catch it.Data:
internal/plugin/count/counts.jsonre-vendored from a regenerated artifact rather than hand-edited (it carries a DO-NOT-HAND-EDIT marker). Counts are identical — 129/127 free, 46/46 licensed, 171 advertised; onlysources.pro.repoand the two source blob SHAs change. The generator fix lives in nself-org/plugins.Remaining
plugins-prohits in the tree are intentional: local-directory paths (../plugins-pro/paidsibling lookups in doctor/model detection), historical changelog entries, and a commented-out branch-protection line.Full
go build ./...andgo test ./...green.