Refactor rosidl_buffer_registry to use modern CMake targets - #1
Open
karsten-nvidia wants to merge 2 commits into
Open
karsten-nvidia wants to merge 2 commits into
karsten-nvidia wants to merge 2 commits into
Conversation
Replace deprecated ament_target_dependencies() with modern CMake target_link_libraries() using namespace targets (rmw::rmw, rosidl_runtime_cpp::rosidl_runtime_cpp, pluginlib::pluginlib). This pattern aligns with other modern ROS 2 packages (pluginlib, class_loader) and resolves build issues when ament_cmake is used without ament_cmake_ros. Changes: - Line 33: target_link_libraries(PUBLIC) instead of ament_target_dependencies() - Line 73: Same pattern for test target Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
karsten-nvidia
added a commit
to karsten-nvidia/ros2
that referenced
this pull request
Feb 5, 2026
Point to karsten-nvidia forks with circular dependency fixes: - class_loader: Remove ament_cmake_ros dependency - rosidl: Refactor rosidl_buffer_registry to modern CMake targets These changes resolve circular dependency blocking ROS 2 builds on the rcl_buffer branch. Related: - class_loader PR: https://github.com/karsten-nvidia/class_loader/tree/fix-circular-dependency-remove-ament-cmake-ros - rosidl PR to nvcyc: nvcyc/rosidl#1 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
karsten-nvidia
force-pushed
the
rolling-native-buffer
branch
from
February 5, 2026 05:06
f616b32 to
e19b529
Compare
nvcyc
force-pushed
the
rolling-native-buffer
branch
from
February 6, 2026 19:37
c38418d to
e6dff7d
Compare
nvcyc
force-pushed
the
rolling-native-buffer
branch
from
March 13, 2026 04:55
c874df7 to
980eea0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace deprecated
ament_target_dependencies()with modern CMaketarget_link_libraries()using namespace targets.Changes
ament_target_dependencies()totarget_link_libraries(PUBLIC)rmw::rmw,rosidl_runtime_cpp::rosidl_runtime_cpp,pluginlib::pluginlibMotivation
Testing
Related
This change works in conjunction with removing ament_cmake_ros dependency from class_loader to resolve circular dependencies in the ROS 2 build system.