Repository navigation
docs(revenue/approvals): zh nav labels, action view names, Completed includes cancelled - #1979
Merged
Merged
Conversation
…includes cancelled - zh-Hans / zh-Hant spell the Inbox entry and its My Work group as the app's zh-CN pack renders them (Traditional script on zh-Hant). - The three sys_approval_action views take the approvals plugin's zh-CN labels, without the English-plus-gloss form (ruling C on #1552). - Completed is described as including cancelled on all three faces, matching the installed plugin's completed filter (17.5.0). - The Inbox and action-view pins move to per-face expectations. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X8U3asekbiC7yWoEPWR4Dg
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Author
|
ACCEPT — #1976: Three changes, all on
Every check is green on Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1976
Follow-up to #1552 / #1971 on
content/docs/revenue/approvals.*. Three items, one PR.Mapping per face
nav_approval_requests)src/sales/translationszh-CN pack (packFor('zh-CN'))group_work)sys_approval_action.recent)@objectstack/plugin-approvals17.5.0, zh-CN blocksys_approval_action.by_actor)sys_approval_action.all_actions)completedview filterstatus in [approved, rejected, recalled, cancelled]cancelled(the plugin's option label isCancelled); zh pages use the plugin's zh-CN status option label 已作废, in Traditional characters on zh-Hant.**Recent**(最近)is dropped on both zh pages, per ruling C.quotedFromConsolepins it against the console bundle.Test pins moved (
test/docs-revenue-approvals-navigation.test.ts)names the real sidebar item:toContain('Inbox')now checks the per-faceinboxLabel. en ='Inbox', zh-Hans = the zh-CN pack value ofnav_approval_requests, zh-Hant =toHantof that value.lists the audit-trail views too: the check moved fromACTION_VIEWSto the per-faceactionViews. en =ACTION_VIEWS, zh-Hans = plugin zh-CN labels read through docs(zh): approvals spells plugin-owned view and tab names from the owner zh-CN pack #1971'sZH_CN_PLUGIN_OBJECTS, zh-Hant =toHant.zhHansViews(schema), used for both objects. The inline Hant replace chain becametoHant. The map gained one character, 执 to 執 (for 按执行人). 审 to 審 and 发 to 發 were already there.test/for Inbox, My Work, 我的工作, Recent, By Actor, 按执行人, 已作废 and recalled. The hits indocs-quick-tour-navigation,docs-setup-navigation-namesandapp-navigation-shapepin source labels or other pages, and all of them stay green.Reverse check, run once and not kept: I mutated the zh-Hans action views back to
**Recent** / **By Actor** / **All**.lists the audit-trail views toothen failed for the zh-Hans face (exit 1). I restored the file withgit checkout HEAD -- …, and its hash matched the HEAD blob.Verification
At head
b4010c74,pnpm verifyexited 0. It ran validate, typecheck, lint, lint:i18n-gate, hygiene, hygiene:tokens, build and test. Tests: 173 files passed, 3725 tests passed, 1 skipped (pre-existing).Acceptance notes
revenue/approvalsnames five plugin-owned views in English and #1329's ruling cannot reach them #1552's principle, maintainer 「繁体用繁体」) and to match the zh-Hant page's own standing sentence (pack-carried, so Traditional form). It is recorded here in case AGENTS.md §6 wants a word for nav labels.🤖 Generated with Claude Code
https://claude.ai/code/session_01X8U3asekbiC7yWoEPWR4Dg