Skip to content

docs(revenue/approvals): zh nav labels, action view names, Completed includes cancelled - #1979

Merged
os-warren merged 1 commit into
mainfrom
claude/issue-1976-approvals-followups
Oct 1, 2026
Merged

os-warren merged 1 commit into
mainfrom
claude/issue-1976-approvals-followups

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Fixes #1976

Follow-up to #1552 / #1971 on content/docs/revenue/approvals.*. Three items, one PR.

Mapping per face

English (en page) Owner of the label zh-Hans zh-Hant
Inbox (nav nav_approval_requests) this app, src/sales/translations zh-CN pack (packFor('zh-CN')) 待我审批 待我審批
My Work (group group_work) this app, zh-CN pack 我的工作 我的工作 (no character changes)
Recent (sys_approval_action.recent) @objectstack/plugin-approvals 17.5.0, zh-CN block 最近 最近
By Actor (sys_approval_action.by_actor) plugin zh-CN block 按执行人 按執行人
All (sys_approval_action.all_actions) plugin zh-CN block 全部 全部
Completed row: "approved, rejected or recalled" plugin completed view filter status in [approved, rejected, recalled, cancelled] 已批准、已拒绝、已撤回或已作废 已批准、已拒絕、已撤回或已作廢
  • The cancelled label follows each page's register: en lowercase prose cancelled (the plugin's option label is Cancelled); zh pages use the plugin's zh-CN status option label 已作废, in Traditional characters on zh-Hant.
  • The English-plus-gloss form **Recent**(最近) is dropped on both zh pages, per ruling C.
  • The zh pages now say that the sidebar entry, the centre's first tab and the object's first view all show 待我审批 in the zh-CN console. That is one prose sentence and adds no assertion.
  • The denials are unchanged: there is no Approval Requests nav entry and no Action History.
  • zh-Hant keeps the Simplified console quote 「待我审批」 in the Inbox bullet. quotedFromConsole pins it against the console bundle.

Test pins moved (test/docs-revenue-approvals-navigation.test.ts)

  • names the real sidebar item: toContain('Inbox') now checks the per-face inboxLabel. en = 'Inbox', zh-Hans = the zh-CN pack value of nav_approval_requests, zh-Hant = toHant of that value.
  • lists the audit-trail views too: the check moved from ACTION_VIEWS to the per-face actionViews. en = ACTION_VIEWS, zh-Hans = plugin zh-CN labels read through docs(zh): approvals spells plugin-owned view and tab names from the owner zh-CN pack #1971's ZH_CN_PLUGIN_OBJECTS, zh-Hant = toHant.
  • Refactor only: docs(zh): approvals spells plugin-owned view and tab names from the owner zh-CN pack #1971's inline zh-CN lookup became zhHansViews(schema), used for both objects. The inline Hant replace chain became toHant. The map gained one character, 执 to 執 (for 按执行人). 审 to 審 and 发 to 發 were already there.
  • No other test pins a changed string. I grepped test/ for Inbox, My Work, 我的工作, Recent, By Actor, 按执行人, 已作废 and recalled. The hits in docs-quick-tour-navigation, docs-setup-navigation-names and app-navigation-shape pin source labels or other pages, and all of them stay green.
  • No new assertions, no skips.

Reverse check, run once and not kept: I mutated the zh-Hans action views back to **Recent** / **By Actor** / **All**. lists the audit-trail views too then failed for the zh-Hans face (exit 1). I restored the file with git checkout HEAD -- …, and its hash matched the HEAD blob.

Verification

At head b4010c74, pnpm verify exited 0. It ran validate, typecheck, lint, lint:i18n-gate, hygiene, hygiene:tokens, build and test. Tests: 173 files passed, 3725 tests passed, 1 skipped (pre-existing).

Acceptance notes

🤖 Generated with Claude Code

https://claude.ai/code/session_01X8U3asekbiC7yWoEPWR4Dg

…includes cancelled

- zh-Hans / zh-Hant spell the Inbox entry and its My Work group as the
  app's zh-CN pack renders them (Traditional script on zh-Hant).
- The three sys_approval_action views take the approvals plugin's zh-CN
  labels, without the English-plus-gloss form (ruling C on #1552).
- Completed is described as including cancelled on all three faces,
  matching the installed plugin's completed filter (17.5.0).
- The Inbox and action-view pins move to per-face expectations.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01X8U3asekbiC7yWoEPWR4Dg
@vercel

vercel Bot commented Oct 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
hotcrm Ignored Ignored Oct 1, 2026 2:53am UTC

Request Review

@github-actions github-actions Bot added documentation Improvements or additions to documentation ci/cd CI plumbing and the verification pipeline labels Oct 1, 2026
@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

ACCEPT — #1976: revenue/approvals follow-ups to #1552.

Three changes, all on revenue/approvals:

  • Sidebar labels: Inbox and My Work are spelled from this app's zh-CN pack: 待我审批 / 我的工作. zh-Hant uses the Traditional script, per the maintainer: 「繁体用繁体」.
  • sys_approval_action views: Recent, By Actor and All now use the plugin's zh-CN labels (最近 / 按执行人 / 全部), with no gloss. The test checks them per face, the same pattern as docs(zh): approvals spells plugin-owned view and tab names from the owner zh-CN pack #1971.
  • Completed view: the description now names cancelled on all three faces. The plugin's zh-CN label for that status is 已作废, not the card's 已取消, so the zh pages use the shipped string.

Every check is green on b4010c74, and local pnpm verify passes. Marking ready and enabling auto-merge; #1976 closes on merge.


Generated by Claude Code

@os-warren
os-warren marked this pull request as ready for review October 1, 2026 02:58
@os-warren
os-warren added this pull request to the merge queue Oct 1, 2026
Merged via the queue into main with commit fb408a7 Oct 1, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cd CI plumbing and the verification pipeline documentation Improvements or additions to documentation

Projects

None yet

2 participants