Repository navigation
docs(sales): 把商机详情页 aside 区的两条描述写实(#959) - #967
Merged
Merged
Conversation
The "when you open an opportunity, you'll see" list promised a Competitors & Notes side panel and an AI Reference Rail of "Sales Copilot suggestions (Customer 360, Revenue Forecast, related signals)". src/pages/opportunity_detail.page.ts declares three regions - header, main and one narrow aside - and the aside holds exactly one component, a record:reference_rail. There is no second panel and no AI component on the page. - Competitors & Notes: no such panel, and nothing on the page renders talking points. Competitors is a multi-select field on the opportunity whose options are still the placeholders Competitor A/B/C, authored in the edit form's Sales Strategy section and not shown on this page; the nearest notes surface is the Details tab's collapsible Description section (Description, Next Steps). - AI Reference Rail: the rail exists, but its three entries are snapshots of already-linked records - Quotes (crm_quote via Opportunity), Products (crm_opportunity_line_item via the same lookup) and Open Tasks (crm_task via Related Opportunity) - each a total-count badge, at most three records and a View all link, with empty entries folded into a "+ N empty" chip. No suggestion is produced here or anywhere on the page; the skills are reached by asking, as the section below already says. The rail's Open Tasks entry carries no status filter (entries declare none and the rail queries on the relationship alone), so the filtered not-Completed list is the Related tab's. Names are kept and answered rather than silently deleted, following #956. English, Simplified Chinese and Traditional Chinese; no metadata changed. Co-authored-by: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This was referenced Aug 6, 2026
yinlianghui
marked this pull request as ready for review
August 6, 2026 14:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #959
content/docs/sales/opportunities{,.zh-Hans,.zh-Hant}.mdx的「当你打开一个商机时,会看到」清单里,:151承诺了一块 Competitors & Notes 侧面板,:152把参考栏说成 Sales Copilot suggestions(Customer 360、营收预测、相关信号)。按src/pages/opportunity_detail.page.ts复核:该页声明三个区域——header、main、以及一条width: 'small'的aside——aside里只有一个组件,record:reference_rail。没有第二块侧面板,整页也没有任何 AI 组件。复核结论(premise 成立)
立单时的行号在
origin/main=4705aed5上仍是:151/:152,三语同址;本页#866(PR #934)动过的:148报价链接零改动。issue 正文列的 aside 实况逐项复核为真,并把「对象 / 过滤 / limit」一并核准写实:crm_quotecrm_opportunity(Opportunity)crm_opportunity_line_itemcrm_opportunity(Opportunity)crm_taskrelated_to_opportunity(Related Opportunity / 关联商机)补测到位、这次一并写进文档的两点:
@objectstack/console产物为准测量(dist/assets/plugins-views-*.js:$filter:{[relationshipField]:parentId}, $top: limit ?? 3, $count:true)。filter: status neq completed,limit: 10)。改动
:151/:152两行 × 三语,沿 #956 的口径:点名说清 + 给出真实归属,不静默删名。#612(全站 Copilot 用语定调)与本条相邻但不同:即使用语保留 Copilot 品牌,:152描述的内容仍然是错的,两条互不等待。src/零改动;content/docs/releases/未触碰;zh 内链不带锚。验证
flock -w 7200 /tmp/os-heavy-verify.lock内串行跑六道门,全部 exit 0:pnpm validate✓ Validation passed (1202ms)(5 条既有 author-time 警告,与本改动无关)pnpm typechecktsc --noEmit无输出pnpm lint13 warning(s), 14 suggestion(s),均为既有项pnpm hygiene✓ no raw control bytes in first-party files/✓ source hygiene cleanpnpm build✓ Build complete (1527ms),dist/objectstack.json1921.4 KBpnpm test -- --maxWorkers=2Test Files 71 passed (71)/Tests 1631 passed | 1 skipped (1632)守卫盲区如实报告:本仓没有任何测试断言这三份 mdx 的这两行文本,也没有 docs↔page-metadata 的一致性门,所以这两行的改动在六道门下 predicted GREEN——门的绿不是本改动正确性的证据,正确性由上表逐项对着
src/pages/opportunity_detail.page.ts:227-256与实际装的 console 产物测量得到。测试输出里那几行✗ source hygiene failed: ...是 hygiene 自检测试自己的负例装置(断言检查器在植入违规时会失败),不是失败。未起 dev server;文档改动,用户可见,已附 changeset
.changeset/opportunity-detail-aside-write-real.md。Generated by Claude Code