Skip to content

UI copy: rename indicator owner_unit label to 「部门板块」 per glossary §1.4 - #14

Merged
baozhoutao merged 1 commit into
mainfrom
issue-13-department-segment-label
Sep 2, 2026
Merged

baozhoutao merged 1 commit into
mainfrom
issue-13-department-segment-label

Conversation

@baozhoutao

@baozhoutao baozhoutao commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

Work item: #13 (P3, UI copy alignment). Base: main @ 50ab3ac (already contains #10).

改动内容(3 处,均为文案 / 术语,零行为改动)

文件 改动 性质
src/objects/indicator.object.ts:34 owner_unit 的 label 「责任板块(考核部门)」 → 「部门板块」 用户可见文案
src/lib/aggregate.ts:6 头部注释「所属板块得分」 → 「部门板块得分」 注释;汇总算法一字未动
src/translations/index.ts:9 kpi_indicator.owner_unit 英文回退 Owning Unit → Department Segment 英文回退,保持语义

依据:需求 V1.3 §1.4 术语表(「部门板块 = 指标的责任部门(考核部门)」)、设计方案 V1.0 已统一为「部门板块」、os-project-std-copy 红线③(名词按术语表)。

owner_unit 字段本身无 help text,故第 1 条中的「帮助文本同步」无对应改动点。

划界扫描(为什么只有这 3 处)

全仓检索「板块」共 5 处 src 命中,逐处判定:

  • src/objects/plan.object.ts:270 / 276 / 290(到人分工 unit 字段 label 与 description)—— 已经是「部门板块」,无需改;
  • src/hooks/plan.hook.ts:104 注释「员工 · 板块」—— 描述自动生成的显示名格式,非术语实例,未改;
  • test/、scripts/ 内「板块」零命中,故无测试断言文案需要跟改。

文档侧:docs/00 已是「部门板块」;docs/01~03 是过程快照,按工作项边界不改;docs/04、docs/05 未引用该 label,故未改。

验证证据(全部在最终提交 c172018 上跑)

  • 验收检索 grep -rn "责任板块\|所属板块" src test scripts → 零命中(退出码 1)。
  • pnpm verify:validation passed(17 objects / 184 fields),typecheck clean,68/68 tests。
  • pnpm e2e(dev 实例 :3113,空库启动):{"passed":73,"failed":0}。
  • 构建产物读回:owner_unit.label = "部门板块";dist/objectstack.json 中「责任板块」0 处。
  • 开测前三级核对:3113 应答;占用进程 cwd = /home/user/kpi-issue-13;worktree HEAD = c172018,工作树干净。

Review gate: MERGEABLE at c172018 (no blocking / should-fix; two notes filed for later: assessor_unit label「考核部门(出指标方)」shares a word with the glossary's gloss for 部门板块, and the English bundle lacks a kpi_staff_assignment entry). Dispatcher collection check passed.

🤖 Generated with Claude Code

https://claude.ai/code/session_01VR2khJ3Me96btawVsfG6jb

Requirements V1.3 §1.4 and design doc V1.0 standardise the term as
「部门板块」, but the indicator field label still used the older
「责任板块(考核部门)」 wording, leaving docs and UI inconsistent.

- src/objects/indicator.object.ts: owner_unit label → 「部门板块」
- src/lib/aggregate.ts: header comment 「所属板块得分」 → 「部门板块得分」
  (wording only; the aggregation algorithm is untouched)
- src/translations/index.ts: en fallback for owner_unit
  「Owning Unit」 → 「Department Segment」, keeping the semantics

No other 「板块」 occurrence in src/test/scripts refers to this term.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VR2khJ3Me96btawVsfG6jb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants