Repository navigation
UI copy: rename indicator owner_unit label to 「部门板块」 per glossary §1.4 - #14
Merged
Merged
Conversation
Requirements V1.3 §1.4 and design doc V1.0 standardise the term as 「部门板块」, but the indicator field label still used the older 「责任板块(考核部门)」 wording, leaving docs and UI inconsistent. - src/objects/indicator.object.ts: owner_unit label → 「部门板块」 - src/lib/aggregate.ts: header comment 「所属板块得分」 → 「部门板块得分」 (wording only; the aggregation algorithm is untouched) - src/translations/index.ts: en fallback for owner_unit 「Owning Unit」 → 「Department Segment」, keeping the semantics No other 「板块」 occurrence in src/test/scripts refers to this term. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VR2khJ3Me96btawVsfG6jb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work item: #13 (P3, UI copy alignment). Base: main @ 50ab3ac (already contains #10).
改动内容(3 处,均为文案 / 术语,零行为改动)
src/objects/indicator.object.ts:34owner_unit的 label 「责任板块(考核部门)」 → 「部门板块」src/lib/aggregate.ts:6src/translations/index.ts:9kpi_indicator.owner_unit英文回退Owning Unit→Department Segment依据:需求 V1.3 §1.4 术语表(「部门板块 = 指标的责任部门(考核部门)」)、设计方案 V1.0 已统一为「部门板块」、os-project-std-copy 红线③(名词按术语表)。
owner_unit字段本身无 help text,故第 1 条中的「帮助文本同步」无对应改动点。划界扫描(为什么只有这 3 处)
全仓检索「板块」共 5 处
src命中,逐处判定:src/objects/plan.object.ts:270 / 276 / 290(到人分工unit字段 label 与 description)—— 已经是「部门板块」,无需改;src/hooks/plan.hook.ts:104注释「员工 · 板块」—— 描述自动生成的显示名格式,非术语实例,未改;test/、scripts/内「板块」零命中,故无测试断言文案需要跟改。文档侧:
docs/00已是「部门板块」;docs/01~03是过程快照,按工作项边界不改;docs/04、docs/05未引用该 label,故未改。验证证据(全部在最终提交
c172018上跑)grep -rn "责任板块\|所属板块" src test scripts→ 零命中(退出码 1)。pnpm verify:validation passed(17 objects / 184 fields),typecheck clean,68/68 tests。pnpm e2e(dev 实例 :3113,空库启动):{"passed":73,"failed":0}。owner_unit.label = "部门板块";dist/objectstack.json中「责任板块」0 处。/home/user/kpi-issue-13;worktree HEAD =c172018,工作树干净。Review gate: MERGEABLE at c172018 (no blocking / should-fix; two notes filed for later:
assessor_unitlabel「考核部门(出指标方)」shares a word with the glossary's gloss for 部门板块, and the English bundle lacks akpi_staff_assignmententry). Dispatcher collection check passed.🤖 Generated with Claude Code
https://claude.ai/code/session_01VR2khJ3Me96btawVsfG6jb