Clarify 'signature' fields by adding '(bench)'#2378
Open
FauziAkram wants to merge 2 commits intoofficial-stockfish:masterfrom
Open
Clarify 'signature' fields by adding '(bench)'#2378FauziAkram wants to merge 2 commits intoofficial-stockfish:masterfrom
FauziAkram wants to merge 2 commits intoofficial-stockfish:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The terms new_signature and base_signature can be unclear for new users of Fishtest. It is not immediately obvious that these fields are intended for the bench value from Stockfish. This can lead to confusion when creating or reviewing tests.
This PR improves usability by making the purpose of these fields explicit. It appends the suffix (bench) to the labels wherever they appear in the UI.
The updated labels are now:
new_signature (bench)
base_signature (bench)
instead of:
new_signature
base_signature