Skip to content

Clarify 'signature' fields by adding '(bench)' #2378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FauziAkram wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Clarify 'signature' fields by adding '(bench)' #2378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1612870
Update tests_run.mak
FauziAkram Aug 25, 2025
731e4c5
Update views.py
FauziAkram Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions server/fishtest/templates/tests_run.mak
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@
</div>

<div class="mb-2 col-6">
<label for="test-signature" class="form-label">Test Signature</label>
<label for="test-signature" class="form-label">Test Signature (bench)</label>
<input
type="number"
name="test-signature"
Expand All @@ -262,7 +262,7 @@
</div>

<div class="mb-2 col-6">
<label for="base-signature" class="form-label">Base Signature</label>
<label for="base-signature" class="form-label">Base Signature (bench)</label>
<input
type="number"
name="base-signature"
Expand Down
8 changes: 7 additions & 1 deletion server/fishtest/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1565,13 +1565,19 @@
if name not in run["args"]:
continue

display_name = name
if name == "new_signature":
display_name = "new_signature (bench)"
elif name == "base_signature":
display_name = "base_signature (bench)"

value = run["args"][name]
url = ""

if name == "new_tag" and "msg_new" in run["args"]:
value += " (" + run["args"]["msg_new"][:50] + ")"

if name == "base_tag" and "msg_base" in run["args"]:

Check failure on line 1580 in server/fishtest/views.py

View workflow job for this annotation

GitHub Actions / check (3.13, 23.x)

Ruff (invalid-syntax) 

server/fishtest/views.py:1580:1: invalid-syntax: Unexpected indentation

Check failure on line 1580 in server/fishtest/views.py

View workflow job for this annotation

GitHub Actions / check (3.13, 23.x)

Ruff (invalid-syntax) 

server/fishtest/views.py:1580:1: invalid-syntax: Unexpected indentation
value += " (" + run["args"]["msg_base"][:50] + ")"

if name in ("new_nets", "base_nets"):
Expand Down Expand Up @@ -1638,7 +1644,7 @@
if name == "spsa":
run_args.append(("spsa", value, ""))
else:
run_args.append((name, html.escape(str(value)), url))
run_args.append((display_name, html.escape(str(value)), url))

active = 0
cores = 0
Expand Down Expand Up @@ -1800,7 +1806,7 @@
page_size = 25

finished_runs, num_finished_runs = request.rundb.get_finished_runs(
username=username,

Check failure on line 1809 in server/fishtest/views.py

View workflow job for this annotation

GitHub Actions / check (3.13, 23.x)

Ruff (invalid-syntax) 

server/fishtest/views.py:1809:1: invalid-syntax: Expected a statement

Check failure on line 1809 in server/fishtest/views.py

View workflow job for this annotation

GitHub Actions / check (3.13, 23.x)

Ruff (invalid-syntax) 

server/fishtest/views.py:1809:1: invalid-syntax: Expected a statement
success_only=success_only,
yellow_only=yellow_only,
ltc_only=ltc_only,
Expand Down
Loading