Repository navigation
[feat] Give the operator pages a favicon - #20
Merged
Merged
Conversation
Both pages declared an empty data: icon, so browser tabs showed nothing. Use the Mirall M and its orange square from the repo's logo, inlined as an SVG data URI so it works under any proxy prefix and with the status page's routes turned off.
A fetch parked on docker-proxy's accepted-but-silent socket did not hold the event loop open, so the process drained mid-await and every test in the file was cancelled. Hold the loop with an interval and time each request out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both pages declared
<link rel="icon" href="data:,">, which silences the browser's/favicon.icorequest but leaves the tab with no icon at all.They now share one icon: the Mirall M and its orange square, taken from the path and colour in
docs/media/logo-*.svg, on a dark rounded tile so it reads on light and dark tab strips.It is an inline
data:image/svg+xmlURI insrc/operator/html.jsrather than a served file, because the two pages sit under different prefixes behind platform proxies,MIRALL_RELAY_ADMIN_UI=falseremoves the status page's routes, and the CSP already allowsimg-src data:. No new route, no new asset to ship.Testing
npm run lintclean,npm testgreen.