rebuild - #6324
Closed
jburel wants to merge 4 commits into
Closed
Conversation
Member
Author
|
I did another workflow:
|
Member
|
Tested various scenarios using the following Dockerfile FROM ubuntu:20.04
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
openjdk-8-jdk \
git \
maven \
libmcpp-dev \
python3-pip \
wget
RUN wget -q https://github.com/ome/zeroc-ice-ubuntu2004/releases/download/0.2.0/ice-3.6.5-0.2.0-ubuntu2004-amd64.tar.gz && \
tar xf ice-3.6.5-0.2.0-ubuntu2004-amd64.tar.gz && \
mv ice-3.6.5-0.2.0 ice-3.6.5 && \
mv ice-3.6.5 /opt && \
rm ice-3.6.5-0.2.0-ubuntu2004-amd64.tar.gz
ENV PATH=/opt/ice-3.6.5/bin:$PATH
RUN git clone https://github.com/ome/openmicroscopy /src/openmicroscopy --depth 1
RUN git clone https://github.com/ome/bioformats /src/bioformats --depth 1
RUN git clone https://github.com/ome/ZarrReader /src/ZarrReader
# Step 1: build Bio-Formats
WORKDIR /src/bioformats
RUN mvn install -DskipTests
# Step 2: build ZarrReader
WORKDIR /src/ZarrReader
#RUN git fetch origin pull/38/merge && git checkout FETCH_HEAD
#RUN mvn install -DskipTests
# Step 3: build OMERO
WORKDIR /src/openmicroscopy
RUN python3 build.py
RUN python3 build.py
|
Member
|
At least for the last few builds, the behavior is pretty consistent: The Maven build system downloads the POMs of all transitive dependencies (e.g. This seems to be incompatible with assumptions of the Ivy configuration which expects both the JAR & the POM to be available and fails the resolution otherwise. Next I will try and enable verbose logging to see if the debugging statements give a hint on how to fix these resolution issues and/or adjust the upstream dependencies. |
Member
|
For the 1+2+3 scenario bumping logback-classic in ome-common should be enough to resolve. Also for the other scennario JM mentioned: Resulting in For this scenario, bumping testng to 6.10 in ZarrReader (and I would also bump Bio-Formats) resolves the issue. |
Member
|
Along with the logback bump in common adding |
Member
|
@dgault one idea: would changing the order of the dependencies in the ZarrReader pom e.g. to pu formats-api at the top and/or adding ome-common first as in the Bio-Formats pom help in unifying the dependency order? |
Member
Simply adding to ZarrReader seemed to be enough to get things to build but bumping them all to keep things aligned would make sense if we were taking that approach |
Closed
Member
Author
|
I have replaced this PR by #6326 |
Member
|
As we wanted to make a decision re releasing OMERO.server 5.6.5 with/without the ZarrReader by tomorrow, what is the current consensus? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR highlights the failure introduced by the ZARR reader.
Running
./build.pywill work in the.m2folder is empty.If it is not it will fail with
This PR introduced a
rebuildstep to highlight the issueA failure is expected.
cc @sbesson