Refactor AccordionItem to work standalone without Accordion wrapper#737
Closed
nourmalaeb wants to merge 1 commit intodevfrom
Closed
Refactor AccordionItem to work standalone without Accordion wrapper#737nourmalaeb wants to merge 1 commit intodevfrom
nourmalaeb wants to merge 1 commit intodevfrom
Conversation
…se on top Create Collapsible, CollapsibleTrigger, and CollapsibleContent as standalone primitives wrapping React Aria's Disclosure. The height animation logic is extracted from AccordionContent into CollapsibleContent so it can be reused independently. Accordion components now compose on top of Collapsible, preserving all existing behavior.
8 tasks
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
nourmalaeb
changed the title
Collaborator
Author
|
Work consolidated into #738 (rebased onto dev directly). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AccordionItemto own its ownvariantprop ('default' | 'unstyled') and provide style context to children, so it works standalone without an<Accordion>wrapperAccordionbecomes a thin layout wrapper (flex flex-col gap-3+DisclosureGroupbehavior) — no longer sets style contextrootslot fromaccordionStyles(layout is baked directly intoAccordion)collapsible.tsxandCollapsible.stories.tsx— no longer needed sinceAccordionItemserves this purposevariant="unstyled"usage from<Accordion>to<AccordionItem>inPhasesSectionContent,RubricEditorContent, and Storybook stories./Collapsibleexport from@op/uipackage.jsonTest plan
pnpm typecheckpassespnpm format:checkpasses<AccordionItem>works without<Accordion>parent