Add collapsible proposal template field cards#738
Draft
nourmalaeb wants to merge 6 commits intodevfrom
Draft
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
nourmalaeb
force-pushed
the
collapsible-proposal-template-fields
branch
2 times, most recently
from
a4d8fb7 to
ab4bf05
Compare
5 tasks
…se on top Create Collapsible, CollapsibleTrigger, and CollapsibleContent as standalone primitives wrapping React Aria's Disclosure. The height animation logic is extracted from AccordionContent into CollapsibleContent so it can be reused independently. Accordion components now compose on top of Collapsible, preserving all existing behavior.
Replace FieldConfigCard usage with CollapsibleConfigCard in the proposal template editor. Cards now have a collapsed header showing icon pill, badge chip, and chevron, with an expanded body containing field name input, type selector, description, config options, and a footer with required toggle and delete button. - Add CollapsibleConfigCard component with collapsible/locked variants - Add changeFieldType mutator to proposalTemplate.ts - Refactor FieldCard with type selector, char counter, and collapsible state - Update TemplateEditorContent with expand tracking and field type changes - Make BudgetFieldConfig collapsible with badge label - Add translation keys (Field name, Type, Optional, Untitled field)
Move variant prop from Accordion to AccordionItem so it can be used standalone (e.g. in CollapsibleConfigCard) without needing an Accordion parent. Delete collapsible.tsx since AccordionItem now serves that role.
nourmalaeb
force-pushed
the
collapsible-proposal-template-fields
branch
from
472f0d5 to
7f17b15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AccordionItemto own its ownvariantprop ('default' | 'unstyled') so it works standalone without an<Accordion>wrapperAccordionbecomes a thin layout wrapper — no longer sets style contextcollapsible.tsxandCollapsible.stories.tsx(no longer needed)CollapsibleConfigCardcomponent using standalone<AccordionItem variant="unstyled">FieldCard,TemplateEditorContent, andBudgetFieldConfigfromFieldConfigCardtoCollapsibleConfigCardchangeFieldTypemutator toproposalTemplate.ts(discards old type-specific data, preserves title/description/required)Field name,Type,Optional,Untitled fieldTest plan
pnpm typecheckpassespnpm format:checkpasses