Skip to content

fix(ui): synchronize WebSSH dimensions and normalize action columns - #454

Merged
singchia merged 2 commits into
mainfrom
fix/webssh-initial-pty-size
Oct 1, 2026
Merged

singchia merged 2 commits into
mainfrom
fix/webssh-initial-pty-size

Conversation

@singchia

@singchia singchia commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Synchronize measured xterm dimensions before SSH open and again on ready/reconnect; avoid resize frames before SSH readiness.
  • Fit device/cluster action columns to their content and align headers/actions to the left.
  • Share opaque header, row and hover surfaces for sticky action cells across device, Kubernetes and legacy packet tables.
  • Document the action-column contract in AGENTS.md and the frontend design language.

Related: #452, #453. Keep both issues open for public verification after labeling resolved.

Validation

  • make build-web passed.
  • 79 tests passed across XTerminal, DeviceShell, Edges, Clusters and Kubernetes.
  • Real SSH through the deployed frontend: initial PTY 147x46, resized 94x29, reconnect 94x29; top rendering verified.
  • Deployed device list: dark/light, hover, left alignment and trailing spacing verified.
  • Browser fixture validation: Kubernetes Nodes/Workloads/Pods/Events and a low-action cluster list, dark/light, horizontal scrolling and screenshots. This is UI validation, not a real Kubernetes integration test.
  • Legacy unrouted list pages were updated and build-checked, not independently browser-tested.

Deployment and rollback

Only nginx on the test environment was updated to ongrid-web:fix-action-tables-20261001. Manager, Edge, protocols and data are unchanged. Restore the prior Compose override/image (ongrid-web:fix-device-actions-20261001-r2) to roll back.

No release tag or website update.

Author confirmation

Refs #452. Register resize before fitting and refresh dimensions across the SSH handshake.
Refs #453. Share opaque row/header/hover surfaces, fit action columns to content and document the layout contract.
@singchia
singchia merged commit 760713a into main Oct 1, 2026
7 of 8 checks passed
@singchia
singchia deleted the fix/webssh-initial-pty-size branch October 1, 2026 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant