Repository navigation
Desktop: fix the clippy 1.98 lints in menu.rs and vfs.rs - #1933
Closed
michielbdejong wants to merge 1 commit into
Closed
michielbdejong wants to merge 1 commit into
michielbdejong wants to merge 1 commit into
Conversation
`cargo clippy -p atomic-server-tauri --all-targets -- -D warnings` failed on develop with clippy 1.98: - menu.rs: `AboutMetadata` is only used on macOS, so the import is unused elsewhere. Import it under the same `cfg`. - vfs.rs: `hash.to_hex().to_string()` where a `&str` is wanted; the hex string derefs to one. - vfs.rs (bench test): `mib as f64` casts an `f64` to itself. Closes #1916 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011KbrNpTmoDhqsVVrSxb64R
Member
|
Trekmeester: included in batch #1915 (run 36779344325). It lands with it when green; if this PR's own tests fail there, I take it out and say why here. |
Member
joepio
added a commit
that referenced
this pull request
Oct 1, 2026
Member
|
Merged into develop through batch #1947 (squash Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
closes #1916
cargo clippy -p atomic-server-tauri --all-targets -- -D warningsfails on develop (c2e2682) with clippy 1.98.1. The three errors are the same ones seen on the candidate line:desktop/src/menu.rs:AboutMetadatais only used inside#[cfg(target_os = "macos")], so on Linux and Windows the import is unused. It's now imported under the samecfg.desktop/src/vfs.rs:451:hash.to_hex().to_string()is passed where a&stris wanted. The hex string derefs to one, so&hash.to_hex()is enough.desktop/src/vfs.rs:2173(a bench test):mib as f64casts anf64to itself.No behaviour change.
Checklist
cargo clippy -p atomic-server-tauri --all-targets -- -D warnings: 3 errors before, clean after, on Linux. The macOS-only path compiles the same as before, since only the import moved.🤖 Generated with Claude Code
https://claude.ai/code/session_011KbrNpTmoDhqsVVrSxb64R
Generated by Claude Code