Batch 2026-09-30: account menu, settings dialogs, share select, document images, onboarding recovery, table quick filter, view tabs, and fixes (13 PRs)

[joepio]

Requested by Joep

Before: four finished PRs from the UI fixes thread sat open. Since #1661, pushes to a PR no longer run the full pipeline, so none of them had an e2e verdict.

After: they sit together on one branch off develop (dd6a959), and one Mancave run decides them. Merge this with a merge commit, not squash: then each included PR head is in develop and GitHub marks it as merged.

Included, at these heads:

• Edit agents, skills and MCP servers in a dialog #1889 Edit agents, skills and MCP servers in a dialog
• Replace the sidebar App panel with an account menu #1890 Replace the sidebar App panel with an account menu
• Keep the share dialog's role select open when clicked #1891 Keep the share dialog's role select open when clicked
• Show document images from the local blob store #1895 Show document images from the local blob store
• Added after run 8 (which was green on 0c5cf10) to save a Mancave run, since develop had moved and a new run was needed anyway:
  • Serve an agent profile stored under another spelling of its key #1945 Serve an agent profile stored under another spelling of its key
  • Add a view when choosing a type from a tab, never replace the last one #1902 Add a view when choosing a type from a tab, never replace the last one
  • Table: quick text filter across all columns (#1881) #1894 Table: quick text filter across all columns
  • Redeem a proxy connect return once under StrictMode #1884 Redeem a proxy connect return once under StrictMode
  • Docs: dev port, wuchale OpenRouter key, root CLAUDE.md, UX findings (split out of #1281) #1930 Docs: dev port, wuchale OpenRouter key, root CLAUDE.md, UX findings
  • Add AGENT_WORKFLOW.md: know-how for per-feature agent sessions #1940 AGENT_WORKFLOW.md
  • Design: durable afterCommit for user-installed plugins (#1851) #1888 Design: durable afterCommit for user-installed plugins
  • Desktop: fix the clippy 1.98 lints in menu.rs and vfs.rs #1933 Desktop: clippy 1.98 lints in menu.rs and vfs.rs
    Left out: Ask the drive for its apps again when a view menu opens (#1846) #1904 (conflicts in useDriveApps.live.test.tsx), Calendar: event times, on the viewer's local day (#1802) #1898/Calendar: a Repeat field instead of recurrence JSON (#1801) #1896 (large calendar stacks), Replay a sync delta on the local history before asking the server (#1905) #1920 (sync, needs review), Forms (#875), continuing Polle's #1281 #1923 (Forms), Move the browser workspace to pnpm 11 (split out of #1281) #1931 (pnpm 11), and Hosted builds open on sign-in, not the welcome screen #1911–Stop the sync page repeating account requests every five seconds #1914, Report writes that keep failing to Sentry #1918, Fix Cloud Server setup leaving the node without the drive #1919 (in another batch).
• Fix onboarding recovery, metadata request bursts and local bootstrap #1917 Fix onboarding recovery, metadata request bursts and local bootstrap (added 20:30; its saas pair ontola/atomic-saas#172 merges after this lands)

Decisions made while resolving:

• Fix onboarding recovery, metadata request bursts and local bootstrap #1917: only the four .po catalogs conflicted; they are combined and settled again (2295 entries, de.po keeps its 12 translations). develop's e2e: size the four shards by measured cost #1893 (e2e shard sizing) is merged in too.
• Replace the sidebar App panel with an account menu #1890 vs develop's Make Try Atomic one calm start, and a demo tour that keeps up with you #1876. Replace the sidebar App panel with an account menu #1890 deletes FeedbackMenuItem.tsx and moves feedback into the new AccountMenu (useFeedbackDialog) and FeedbackButton. Since Replace the sidebar App panel with an account menu #1890 branched, Make Try Atomic one calm start, and a demo tour that keeps up with you #1876 made the More menu's "Give feedback" open the sidebar's feedback dialog through OPEN_FEEDBACK_EVENT, with FeedbackMenuItem as the listener. AccountMenu now listens for that event instead, so "Give feedback" still opens the dialog. CrashPage already uses FeedbackButton in Replace the sidebar App panel with an account menu #1890.
• The browser/CHANGELOG.md entries from all four PRs are kept (union).
• Translation catalogs: the conflicting .po files were combined, then settled with pnpm clean-translations. That gives 2295 entries, up from develop's 2288 (the new strings of these PRs), and no translation is lost: de.po still has its 12 translated entries. Most of the line churn is #: reference comments.

Fixes found by the batch runs:

• SearchBoxWindow.test.tsx (from Find already-fetched external classes in New Table's class picker #1842, already on develop) failed run 3 with two unhandled ReferenceError: window is not defined. Its stores connected a WebSocket to server.example. The failed socket reported "Server disconnected", and the resulting React state update landed after jsdom was torn down. The test's stores now use connect: false, as bootstrap.test.ts does.
• Runs 1 and 2 each failed on one different e2e test (ai-chat-discovery "independent signed-in devices…", then canvas-undo "undo works right after a cold reload…"), both on 60 s timeouts while Mancave was running 4 shards at once. On a Mac, against this branch, the first passed 8/8 and the second 24/24 with 6 parallel workers. Develop's own run on Make Try Atomic one calm start, and a demo tour that keeps up with you #1876 failed the same way on ai-mobile.
• Develop moved on while run 5 was green (c2e2682, Make Try Atomic one calm start, and a demo tour that keeps up with you #1876 follow-up): ShowRoute now skips consuming the drive search param while isDriveSignInError says the subject needs a sign-in, and Fix onboarding recovery, metadata request bursts and local bootstrap #1917 makes the same effect wait for selectReadableDrive. Both are kept: the effect returns early on signInRedirect, otherwise waits for a readable drive, then consumes. Its new open-locked-drive.spec.ts clicked the old sidebar a[href$="/app/agent"], which Replace the sidebar App panel with an account menu #1890 replaces, so it now goes through clickAccountMenuItem(page, 'Profile') like Replace the sidebar App panel with an account menu #1890's other sign-out specs. Locally: route/readableDrive/isDriveSignInError vitest 20/20, and open-locked-drive + signout-signin-data 6/6.
• Run 6 failed @tomic/lib's upload-roundtrip.integration.test.ts: the blob was not downloadable within the test's 15 s polling window. Locally it arrives in about 1.2 s both with this branch's websockets.ts and develop's, so Fix onboarding recovery, metadata request bursts and local bootstrap #1917's sync gating does not slow it. On Mancave the whole test takes 10–24 s on develop too. The window is now 45 s, inside the test's 60 s budget.
• Upload traces of failed e2e tests as a CI artifact #1932 was added after run 6 and reverted again. Its Directory.export inside the Dagger module writes into the function's sandbox, not onto the runner, so nothing reached the artifact upload. It gets reworked on its own PR.
• Run 7 failed ai-chat-discovery "independent signed-in devices…" (as run 1 did). It cold-starts a second browser context, whose local database opened too late on Mancave: "ClientDb is running without its local cache". That context's app did not render within signIn's 20 s, and its chat answer did not arrive within 10 s. The test is now test.slow(), allows that ClientDb warning as an optional diagnostic, and waits up to 30 s for both answers. signIn's cold-boot wait is now 45 s; it only takes longer when boot is slow. Locally against a CI-style production build: 6/6.
• Develop moved again after run 8 (List a drive once when its address is spelled two ways #1937, and my SearchBoxWindow fix plus the other offline test stores landed there directly). Merged in cleanly.
• After adding the eight PRs: catalogs settled (2301 entries, de.po keeps its 12 translations), data-browser tsc passes, pnpm run -r lint is clean, and vitest passes 1519 of 1519.

Checked locally on this branch: data-browser tsc --noEmit passes, pnpm --filter @tomic/data-browser lint is clean, and vitest passes (1471 of 1471 after adding #1917, plus @tomic/lib websockets 34 of 34; scripts/integration-mcp.test.mjs is a node:test file vitest can't collect, the same as on develop).