Repository navigation
Conversation
The same public key has been written padded, unpadded, standard and URL-safe. A profile stored under one spelling was invisible to the canonical unpadded subject, which got an empty synthesized agent instead, so one person showed up as two resources.
joepio
marked this pull request as ready for review
September 30, 2026 18:29
This was referenced Sep 30, 2026
Merged
Member
Author
|
Trekmeester: included in batch #1915 (run 36779344325). It lands with it when green; if this PR's own tests fail there, I take it out and say why here. |
Member
Author
Member
Author
|
Landed on develop through the batch #1946 (squash f2a07aa), tested together on Mancave. Closing this PR since its commits are in that batch. Generated by Claude Code |
joepio
added a commit
that referenced
this pull request
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Joep · project thread
Before: a person's agent showed up twice in one session. One copy was titled
joep.iowith name, drive, icon and created-at. The other was titledatomic:agent:<key>(the same key without the trailing=) and showed "Empty" with only a public-key.After: both spellings resolve to the stored profile.
The key has been written padded, unpadded, standard and URL-safe over time, and the stored profile lives under the old padded spelling. The canonical subject is unpadded, finds nothing stored, and the server synthesizes an empty agent from the key (the "just-in-time" path in
get_resource).How: before synthesizing,
get_resourcetries every spelling of the key (identifiers::agent_pubkey_spellings) under bothatomic:agent:anddid:ad:agent:, and serves the stored profile under the requested subject. Nothing is rewritten or migrated, so legacy data stays valid. Test:agent_profile_under_padded_key_answers_for_unpadded_subject.Not covered: rights checks still compare agent subjects as strings, so a grant naming the padded spelling would not match the unpadded signer. Separate change if we want it.
Generated by Claude Code