Skip to content

fix(sdk): keep API-key scan logs after scans finish - #348

Merged
ianw-oai merged 3 commits into
mainfrom
dev/ianw/codex-security-persistent-home
Aug 11, 2026
Merged

fix(sdk): keep API-key scan logs after scans finish#348
ianw-oai merged 3 commits into
mainfrom
dev/ianw/codex-security-persistent-home

Conversation

@ianw-oai

Copy link
Copy Markdown
Collaborator

Changes

  • Use the persistent Codex home for API-key and external-provider scans.
  • Keep session logs after a scan finishes without storing API keys.
  • Keep key-based scans concurrent and preserve stored sign-in behavior.

Checks

  • 102 SDK API tests passed.
  • Type checks passed.
  • Formatting checks passed.

@ianw-oai ianw-oai changed the title Keep API-key scan logs after scans finish fix(sdk): keep API-key scan logs after scans finish Aug 11, 2026
@github-actions github-actions Bot added the bug Something isn't working label Aug 11, 2026

@mldangelo-oai mldangelo-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for preserving API-key session history without persisting the API key, and for covering concurrent key-based scans.

One additional concurrency case may be worth a look: two deep scans now share codex-security/config.toml, and the managed-home lock is released before execution. With the existing resolver, a scan configured with workers=2 and maxDiscoveryRuns=10 observed a concurrent scan's workers=5 and maxDiscoveryRuns=25.

Could we keep deep-scan settings per scan, or otherwise preserve each invocation's requested settings while retaining the shared session home? A concurrent deep-scan regression case would make this particularly clear.

@ianw-oai
ianw-oai merged commit c0ef3c4 into main Aug 11, 2026
17 checks passed
@ianw-oai
ianw-oai deleted the dev/ianw/codex-security-persistent-home branch August 11, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants