fix(sdk): keep API-key scan logs after scans finish - #348
Merged
Conversation
kmbroai
approved these changes
Aug 11, 2026
mldangelo-oai
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for preserving API-key session history without persisting the API key, and for covering concurrent key-based scans.
One additional concurrency case may be worth a look: two deep scans now share codex-security/config.toml, and the managed-home lock is released before execution. With the existing resolver, a scan configured with workers=2 and maxDiscoveryRuns=10 observed a concurrent scan's workers=5 and maxDiscoveryRuns=25.
Could we keep deep-scan settings per scan, or otherwise preserve each invocation's requested settings while retaining the shared session home? A concurrent deep-scan regression case would make this particularly clear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Checks